Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1839 Remove the set-python action from the lambda-functions.yml workflow #1864

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Jul 11, 2024

Description

These changes remove the set-python action from the lambda-functions.yml workflow, which is a legacy step from when we used to bundle dependencies with lambda code upon deployment. (We use layers now.)

issue #1839

Type of change

Please check the relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation changes only
  • other

How Has This Been Tested?

How has this been tested? (e.g. Unit tests, Tested locally, Tested as a GitHub action, Depoyed to dev, etc)
Please provide relevant information and / or links to demonstrate the functionality or fix. (e.g. screenshots, link to deployment, regression test results, etc)

I deployed the VA Profile Opt-in/out lambda to Dev from the master branch using this PR's branch for the workflow. Then I verified in the Lambda console that everything is as expected. I am satisfied that removing the set-python step has no effect on the deployment.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have ensured the latest master is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket is now moved into the DEV test column

@kalbfled
Copy link
Member Author

kalbfled commented Jul 11, 2024

This PR should not be merged before Monday (7/15). Cris has a new plan. Green light.

@kalbfled kalbfled marked this pull request as ready for review July 11, 2024 20:30
@kalbfled kalbfled requested a review from a team as a code owner July 11, 2024 20:30
@kalbfled kalbfled merged commit 9431d02 into master Jul 11, 2024
16 checks passed
@kalbfled kalbfled deleted the 1839-set-python branch July 11, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal For internal updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants