requested changes

department-of-veterans-affairs · Dec 19, 2024 · 3251030 · 3251030
1 parent 114bc09
commit 3251030
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/app/dao/fact_notification_status_dao.py b/app/dao/fact_notification_status_dao.py
@@ -815,7 +815,7 @@ def fetch_monthly_notification_statuses_per_service(
                     else_=0,
                 )
             ).label('count_delivered'),
-            # TODO: remove this after technical-failure is removed from the codebase
+            # TODO 2191 - remove this after technical-failure is removed from the codebase
             func.sum(
                 case(
                     [

diff --git a/app/delivery/send_to_providers.py b/app/delivery/send_to_providers.py
@@ -29,7 +29,7 @@
     get_provider_details_by_notification_type,
 )
 from app.dao.templates_dao import dao_get_template_by_id
-from app.exceptions import NotificationTechnicalFailureException, InvalidProviderException, InactiveServiceException
+from app.exceptions import InactiveServiceException, InvalidProviderException, NotificationTechnicalFailureException
 from app.feature_flags import is_gapixel_enabled, is_feature_enabled, FeatureFlag
 from app.googleanalytics.pixels import build_dynamic_ga4_pixel_tracking_url
 from app.models import (
@@ -294,11 +294,14 @@ def get_html_email_options(notification: Notification) -> Dict[str, Union[str, b
 
 
 def inactive_service_failure(notification: Notification):
-    # notification.status = NOTIFICATION_PERMANENT_FAILURE
-    # dao_update_notification(notification)
+    """Called when the service is inactive to raise InactiveServiceException with the proper error message.
+
+    Raises:
+        InactiveServiceException: always
+    """
     raise InactiveServiceException(
-        f'Send {notification.notification_type} for notification {notification.id} to provider is not allowed: '
-        f'service {notification.service_id} is inactive'
+        f'Send {notification.notification_type} to provider is not allowed. '
+        f'Service {notification.service_id} is inactive. Notification {notification.id}'
     )
 
 

diff --git a/app/service/statistics.py b/app/service/statistics.py
@@ -29,7 +29,7 @@ def format_admin_stats(statistics):
             counts[row.notification_type]['test-key'] += row.count
         else:
             counts[row.notification_type]['total'] += row.count
-            # TODO: remove this after technical-failure is removed from the codebase
+            # TODO 2191 - remove this after technical-failure is removed from the codebase
             if row.status in ('technical-failure', 'permanent-failure', 'temporary-failure', 'virus-scan-failed'):
                 counts[row.notification_type]['failures'][row.status] += row.count
 
@@ -45,7 +45,7 @@ def create_stats_dict():
             stats_dict[template][status] = 0
 
         stats_dict[template]['failures'] = {
-            # TODO: remove this after technical-failure is removed from the codebase
+            # TODO 2191 - remove this after technical-failure is removed from the codebase
             'technical-failure': 0,
             'permanent-failure': 0,
             'temporary-failure': 0,

diff --git a/app/va/identifier.py b/app/va/identifier.py
@@ -3,7 +3,6 @@
 from app.constants import STATUS_REASON_NO_PROFILE
 
 
-# TODO: Refactor this file to have actual classes that contain suffix, oid properties etc instead of all these dicts
 class IdentifierType(Enum):
     VA_PROFILE_ID = 'VAPROFILEID'
     PID = 'PID'