Sitewide integration #837
Open
Sitewide integration #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
Sitewide-integration
branch
from
70dbef9 to
6bdf487
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Combines the contents of
Sitewide-integrationwithmain. This integration branch was created to avoid merging any code intomainbefore Events were successfully deployed to production. Now that the Events deploy has been successfully validated in production, we can move in this code and stop using an integration branch.The code that is in this branch was added as part of the Checklist template code and includes updates to existing components to bring them up to speed with production and updates of the design system dependencies.
Details for each update are in these PRs:
Ticket
Relates to #19386
Developer Task
Tasks
Testing Steps
Explain the steps needed for testing
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Screenshots
Note that testing was specifically regression checks for the
/outreach-and-events/eventspage and individual event pages. Since there were updates to the design system dependencies, spacing here and there has been updated and is expected.Events - Desktop
/outreach-and-events/eventsNote: the underlines on the pagination numbers are also not showing on the
mainbranch, but they appear fine in production - not sure why this is./central-western-massachusetts-health-care/events/73034//outreach-and-events/events/75180/Events - Tablet
/outreach-and-events/eventsEvents - Mobile
/outreach-and-events/events/outreach-and-events/events/75180//central-western-massachusetts-health-care/events/73034/Is this PR blocked by another PR?
DO NOT MERGElabelReviewer
Reviewing a PR
This section lists items that need to be checked or updated when making changes to this repository.
Standard Checks
Tasks
Merging an Approved Layout
When merging a layout, you must ensure that the content type has been turned on for
next-buildinside theCMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.
The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.
Merging a Non-Approved Layout
Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the
mainbranch. It is imperative that we do not push anything live that has not been approved.Ensure that this layout has been added to the templates.md file with the current status of the work.