-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: QA Fixes #783,#784, #19413 #788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…; Update Required conditional
…-build into qa_fixes
ttran-Therisa
changed the title
PR: QA Fixes #783,#784, #19413, #19411
PR: QA Fixes #783,#784, #19413, ~~#19411~~
Oct 8, 2024
ttran-Therisa
changed the title
PR: QA Fixes #783,#784, #19413, ~~#19411~~
PR: QA Fixes #783,#784, #19413
Oct 8, 2024
mreed101
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
ticket [AP] Events with required application have incorrect text for "Application" #783 to change Apply to Application; Lines modified are in event/index.tsx line 203.
the underscore issue in "More details" for ticket [AP] In events, remove underscore on "More details" #784. Lines modified are in event/index.tsx line 233.
the conditions for "Required" in ticket #19413. Lines modified are in event/index.tsx line 199-210.
the business logic to include active ongoing events as the most recent date in date.ts. Lines modified are in event/index.tsx line 196-206.Ticket
For Apply to Application
Relates to #783. (or closes?)
For underscore issue
Relates to #784. (or closes?)
For Required condtion
Relates to #19413. (or closes?)
For the ongoing eventsRelates to #19411. (or closes?)
Relates to #24702. (or closes?)
Developer Task
Tasks
Testing Steps
QA steps
What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?
Screenshots (Ignore)
For tracking and showing ongoing events and future eventsBefore:
After:
Is this PR blocked by another PR?
DO NOT MERGE
labelReviewer
Reviewing a PR
This section lists items that need to be checked or updated when making changes to this repository.
Standard Checks
Tasks
Merging an Approved Layout
When merging a layout, you must ensure that the content type has been turned on for
next-build
inside theCMS
. This CMS flag must be turned on for editors to preview their work using the next build preview server.Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.
The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.
Merging a Non-Approved Layout
Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the
main
branch. It is imperative that we do not push anything live that has not been approved.Ensure that this layout has been added to the templates.md file with the current status of the work.