Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: QA Fixes #783,#784, #19413 #788

Merged
merged 26 commits into from
Oct 8, 2024
Merged

PR: QA Fixes #783,#784, #19413 #788

merged 26 commits into from
Oct 8, 2024

Conversation

ttran-Therisa
Copy link
Contributor

@ttran-Therisa ttran-Therisa commented Oct 8, 2024

Description

This PR fixes

Ticket

For Apply to Application
Relates to #783. (or closes?)
For underscore issue
Relates to #784. (or closes?)
For Required condtion
Relates to #19413. (or closes?)

For the ongoing events
Relates to #19411. (or closes?)
Relates to #24702. (or closes?)

Developer Task

Tasks

Preview Give feedback

Testing Steps

  • Check that events say Application instead of Apply /outreach-and-events/events/66665/
  • Check that the underscore is gone /outreach-and-events/events/64661/
  • Check that the required appears appropriately /outreach-and-events/events/66435/
  • Check that if there is an ongoing event, then show that date and time

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots (Ignore)

For tracking and showing ongoing events and future events
Before:
Screenshot 2024-10-07 at 4 39 43 PM
Screenshot 2024-10-07 at 4 39 50 PM

After:
Screenshot 2024-10-07 at 5 06 24 PM
Screenshot 2024-10-07 at 5 06 07 PM

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 8, 2024 16:05 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 8, 2024 16:32 Destroyed
@ttran-Therisa ttran-Therisa changed the title PR: QA Fixes #783,#784, #19413, #19411 PR: QA Fixes #783,#784, #19413, ~~#19411~~ Oct 8, 2024
@ttran-Therisa ttran-Therisa changed the title PR: QA Fixes #783,#784, #19413, ~~#19411~~ PR: QA Fixes #783,#784, #19413 Oct 8, 2024
@ttran-Therisa ttran-Therisa merged commit 8ca1494 into main Oct 8, 2024
10 checks passed
@ttran-Therisa ttran-Therisa deleted the qa_fixes branch October 8, 2024 17:00
timcosgrove pushed a commit that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants