Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed show all times after it is clicked #777

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

mreed101
Copy link
Contributor

@mreed101 mreed101 commented Oct 3, 2024

Description

This PR brings parity between content-build and next-build by removing the show all times button from the page after the user has already clicked it.

Ticket

N/A

Developer Task

Tasks

Preview Give feedback

Testing Steps

Go to localhost:3000/chicago-health-care/events/53791/
Scroll down to View other times for this event, click it.
Scroll down to the Show all times button, click it.

The show all times button should be removed from that page.

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

Screenshots

Before:
Screenshot 2024-10-03 at 1 20 30 PM

After:
Screenshot 2024-10-03 at 1 20 19 PM

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

Reviewer

Reviewing a PR

This section lists items that need to be checked or updated when making changes to this repository.

Standard Checks

Tasks

Preview Give feedback

Merging an Approved Layout

When merging a layout, you must ensure that the content type has been turned on for next-build inside the CMS. This CMS flag must be turned on for editors to preview their work using the next build preview server.

Resource types (layouts) that have not been approved by design should NOT be pushed to production. Ensure that slug.tsx does not include your resource type if it is not approved.

The status of layouts should be kept up to date inside templates.md. This includes QA progress, development progress, etc. A link should be provided for where testing can occur.

Merging a Non-Approved Layout

Your new resource type should not be included inside slug.tsx. Items added here will go into production once merged into the main branch. It is imperative that we do not push anything live that has not been approved.

Ensure that this layout has been added to the templates.md file with the current status of the work.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 17:25 Destroyed
@jcbolling jcbolling self-requested a review October 8, 2024 14:57
@mreed101 mreed101 self-assigned this Oct 8, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 8, 2024 14:58 Destroyed
Copy link
Contributor

@jcbolling jcbolling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.

@mreed101 mreed101 merged commit 2217160 into main Oct 8, 2024
10 checks passed
@mreed101 mreed101 deleted the jr/show-all-times branch October 8, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants