Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17023 nightly archive workflow #478

Merged
merged 14 commits into from
Mar 29, 2024
Merged

Conversation

tjheffner
Copy link
Contributor

@tjheffner tjheffner commented Mar 27, 2024

Description

Closes #17023.

Adds a separate workflow for archiving a APP_ENV=prod build nightly. This re-uses the same bucket that content-build archives into, however we upload into s3://{{bucket-path}}/next-build/ so there is no fear of overwriting or conflicting with current content-build processes.

This ports over some scripts and custom actions from content-build used for validating the latest passing build.

Testing done

https://github.com/department-of-veterans-affairs/next-build/actions/runs/8458526038/job/23173013746?pr=478

Screenshots

the next-build folder in the archive bucket:
Screenshot 2024-03-27 at 2 22 35 PM
https://console.amazonaws-us-gov.com/s3/buckets/vetsgov-website-builds-s3-upload?region=us-gov-west-1&prefix=next-build/&showversions=false

our archived build:
Screenshot 2024-03-27 at 2 22 39 PM

the 9f233085b8b9f7728195a120404cf1704e29201a name maps to 9f23308 aka the last commit merged to main that successfully passed our ci.yml workflow.

QA steps

Tasks

Preview Give feedback

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 19:31 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 19:41 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 19:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:02 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:04 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:07 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:19 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 20:57 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 21:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 27, 2024 21:29 Destroyed
timcosgrove
timcosgrove previously approved these changes Mar 27, 2024
Copy link
Contributor

@timcosgrove timcosgrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with one tiny non-blocking question

.github/workflows/archive.yml Outdated Show resolved Hide resolved
uses: actions/checkout@v4
with:
repository: department-of-veterans-affairs/next-build
ref: ${{ needs.validate-build-status.outputs.TAG }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the latest workflow run:

Checking out the ref
  /usr/bin/git checkout --progress --force refs/tags/v0.0.111

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 28, 2024 16:59 Destroyed
@tjheffner tjheffner requested a review from timcosgrove March 29, 2024 16:04
Copy link
Contributor

@jschmidt-civicactions jschmidt-civicactions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@tjheffner tjheffner merged commit 8d7da21 into main Mar 29, 2024
10 checks passed
@tjheffner tjheffner deleted the VACMS-17023-archive-workflow branch March 29, 2024 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants