Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17338 test improvements #465

Merged
merged 5 commits into from
Mar 26, 2024
Merged

17338 test improvements #465

merged 5 commits into from
Mar 26, 2024

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented Mar 22, 2024

Description

Relates to #17338

Adds unit tests for many of the components and queries that were missing them. Updates mock data and snapshot tests

Alot of the LoC here is mock data and snapshot changes. Just check .test.tsx files for actual changes

Testing done

Local, tugboat

Screenshots

image

QA steps

Verify tests run

Tasks

Preview Give feedback

Is this PR blocked by another PR?

  • Add the DO NOT MERGE label
  • Add links to additional PRs here:

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 22, 2024 19:07 Destroyed
@jtmst jtmst force-pushed the 17338-test-improvements branch from 421d755 to 228ba6d Compare March 22, 2024 19:13
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 22, 2024 19:13 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 25, 2024 15:00 Destroyed
@jtmst jtmst marked this pull request as ready for review March 25, 2024 15:05
@jtmst jtmst requested review from ryguyk and tjheffner March 25, 2024 15:07
@jtmst jtmst force-pushed the 17338-test-improvements branch from abf4bf9 to 95233fd Compare March 26, 2024 15:18
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 15:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 15:40 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 26, 2024 15:45 Destroyed
@tjheffner tjheffner merged commit 31ad967 into main Mar 26, 2024
12 checks passed
@tjheffner tjheffner deleted the 17338-test-improvements branch March 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants