Update sitemap a11y scan #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch runs locally with Tests running: HTML report home page: HTML report for specific test: |
alexfinnarn
previously approved these changes
Mar 20, 2024
tjheffner
commented
Apr 5, 2024
.github/workflows/a11y.yml
Outdated
| @@ -0,0 +1,158 @@ | |||
| name: A11y Tests | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
once we have all the kinks worked out, let's update this to run on a schedule like thebroken-links-check.yml workflow
Something like:
on:
# Manual trigger
workflow_dispatch:
# Schedule; currently once nightly, at 3:20 UTC.
schedule:
- cron: 20 3 * * *
(I've adjusted the hours from the broken link schedule to offset load on the runners)
There was a problem hiding this comment.
@alexfinnarn everything LGTM, let's bump this to be scheduled and we can merge
tjheffner
commented
Apr 5, 2024
tjheffner
commented
Apr 11, 2024
.github/workflows/a11y.yml
Outdated
| @@ -0,0 +1,158 @@ | |||
| name: A11y Tests | |||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
@alexfinnarn everything LGTM, let's bump this to be scheduled and we can merge
alexfinnarn
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #16117.
Testing done
Running test locally with all the options via CLI, e.g.
BASE_URL=https://va.gov USE_PROXY=false PW_WIDTH_VALUE=768 PW_HEIGHT_VALUE=720 PW_BROWSER_VALUE=firefox SEGMENT_INDEX=0 yarn playwright test --project=a11yScreenshots
QA steps
a11y-scan-1artifact and open it to confirm violations are listed by URL with a valid JSON syntax. The browser name and viewport size should be included with each URL listed.