Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16863: Further work on automated manifest update #441

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

timcosgrove
Copy link
Contributor

Description

Relates to #16863.

Previously we tried using a matrix - so 4 parallel instances - to update the 4 environments for Next Build EKS.

This doesn't work because manifest updates are a 'gitops' operation. We can't do these in parallel because it creates merge conflicts.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 6, 2024 21:32 Destroyed
yq e -i '.deployment.container.image = "008577686731.dkr.ecr.us-gov-west-1.amazonaws.com/dsva/next-build-node:${{ env.IMAGE_TAG }}"' values.yaml
git diff

- name: Add and Commit file, Prod Next Build Test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be simplified to a single add-and-commit at the end here. If the working dir is 'vsp-infra-application-manifests/apps' (or higher) the add for '*.yaml' should recursively add all changed yaml files and it will be one commit.

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2024 18:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 7, 2024 21:08 Destroyed
@timcosgrove timcosgrove merged commit bd5b751 into main Mar 7, 2024
9 checks passed
@timcosgrove timcosgrove deleted the VACMS-16863-auto_deploy branch March 7, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants