VACMS-16863: Trigger manifest update from image creation workflow. #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timcosgrove
commented
Mar 6, 2024
| @@ -88,4 +88,13 @@ jobs: | |||
| docker build . -t $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG -f ./Dockerfile | |||
| docker push $ECR_REGISTRY/$ECR_REPOSITORY:$IMAGE_TAG | |||
|
|
|||
| - name: Write release name as artifact | |||
There was a problem hiding this comment.
This is the same logic as in the production tag creation workflow.
timcosgrove
commented
Mar 6, 2024
|
|
||
| jobs: | ||
| update-manifest: | ||
| if: ${{ !(github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'failure') }} |
There was a problem hiding this comment.
Same as before: if this is triggered by workflow_run and that was a failure, do not run.
timcosgrove
commented
Mar 6, 2024
| strategy: | ||
| fail-fast: false | ||
| max-parallel: 4 | ||
| matrix: |
There was a problem hiding this comment.
This setup is so we can deploy all environments at once.
timcosgrove
commented
Mar 6, 2024
| # If this is triggered via workflow_run, run as a matrix and deploy all | ||
| # apps and envs. | ||
| - name: Update image and helm chart versions (triggered by upstream) |
There was a problem hiding this comment.
If these steps run (because triggered by workflow_run), it will cause the job to be split out into 4 parallel jobs which will deploy each environment.
tjheffner
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #16863.
Triggers manifest update from image creation workflow.