Fix AudienceTopics styles and add types #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjheffner
suggested changes
Jan 30, 2024
| @@ -6,10 +6,11 @@ export function AudienceTopics({ tags }: FormattedAudienceTopics) { | |||
| if (isEmpty(tags)) return null | |||
| const tagsList = tags.map(({ id, href, name }) => ( | |||
| <div key={id}> | |||
| <div className="vads-u-margin-right--1 vads-u-margin-bottom--1 medium-screen:vads-u-margin-bottom--0"> | |||
| <div className="vads-u-margin-right--1 vads-u-margin-bottom--1 medium-screen:vads-u-margin-bottom--1p5"> | |||
| <Link | |||
| href={`${href}/${encodeURI(name)}`} | |||
There was a problem hiding this comment.
i don't think this href is correct. the /${encodeURI(name)} portion can be dropped.
looking at va.gov:
this pr:
/resources/tag/all-veterans/All%20Veterans
tjheffner
reviewed
Jan 30, 2024
src/data/queries/audienceTopics.ts
Outdated
| @@ -3,14 +3,21 @@ import { ParagraphAudienceTopics } from '@/types/drupal/paragraph' | |||
| import { QueryFormatter } from 'next-drupal-query' | |||
| import { AudienceTopic } from '@/types/formatted/audienceTopics' | |||
|
|
|||
| const getTagsList = (fieldTags) => { | |||
| if (!fieldTags) return null | |||
| interface Tag { | |||
There was a problem hiding this comment.
is this needed?
if the formatter is returning AudienceTopic[] but it just calls getTagsList which returns Tag[], can we re-use one or the other?
tjheffner
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
department-of-veterans-affairs/va.gov-cms#16617
Tags for resource and support taxonomies were largely already done. This PR fixes up some styling and adds type safety to the getTags function.
Changes
Testing done
Local
Screenshots
QA steps
Verify tags render as expected in storybook
Is this PR blocked by another PR?
DO NOT MERGElabel