Skip to content

Commit

Permalink
Updates web components, changes assetPrefix to undefined (#594)
Browse files Browse the repository at this point in the history
Co-authored-by: mreed-maphabit <[email protected]>
  • Loading branch information
mreed101 and mreed-maphabit authored Jul 10, 2024
1 parent 9b6ba71 commit 455164e
Show file tree
Hide file tree
Showing 9 changed files with 52 additions and 50 deletions.
Binary file not shown.
Binary file not shown.
29 changes: 29 additions & 0 deletions READMEs/next-build-status.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
## Goal

This document is used to keep track of the current state of the Next Build migration efforts. All Next Build progress and in-flight work will be located in this file.

## Layouts

Completed layouts are currently being tracked in [templates.md] (https://github.com/department-of-veterans-affairs/next-build/blob/main/READMEs/templates.md).
The following templates are in development (7/9/24)

- (Step by Step) [https://github.com/department-of-veterans-affairs/va.gov-cms/issues/8651]

## Applications

Work to handle the migration of applications is still in development. A spike has been completed to investigate how application injection was handled inside of content-build. The application approach is set to mimic what was previously done for content-build. Once this approach has been approved, work will begin on implementation. The tickets for the spike and application work can be found in GitHub

- (Spike) [https://github.com/department-of-veterans-affairs/va.gov-cms/issues/14420]
- (Application) [https://github.com/department-of-veterans-affairs/next-build/issues/575]

## Sitemap

The current sitemap is a combination of the next-build sitemap.xml and content-build sitemap.xml. These files will be referenced by a sitemap index file.

## Live

The following content types are live and being served by next-build.

- N/A

## Troubleshooting
23 changes: 8 additions & 15 deletions READMEs/templates.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,13 @@ The templates in next-build are functional React components. The types or interf

## Available Template List

Developers are required to update this session when creating a new layout.
Developers are required to update this section when adding a new layout.
The following layouts are available in next-build.

- Event
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/outreach-and-events/events/69619/
- Event Listings
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/outreach-and-events/events/
- News Story
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/eastern-oklahoma-health-care/stories/access-va-health-care-during-federal-holidays-and-247-365-with-va-health-connect/
- Press Release
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/southern-nevada-health-care/news-releases/vasnhs-to-host-laughlin-pact-act-veterans-town-hall-june-27/
- Press Release Listings
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/southern-nevada-health-care/news-releases
- Story Listings
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/eastern-oklahoma-health-care/stories/
- Vets Center
- http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/abilene-vet-center
- (Event) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/outreach-and-events/events/69619/]
- (Event Listings) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/outreach-and-events/events/]
- (News Story) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/eastern-oklahoma-health-care/stories/access-va-health-care-during-federal-holidays-and-247-365-with-va-health-connect/]
- (Press Release) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/southern-nevada-health-care/news-releases/vasnhs-to-host-laughlin-pact-act-veterans-town-hall-june-27/]
- (Press Release Listings) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/southern-nevada-health-care/news-releases]
- (Story Listings) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/eastern-oklahoma-health-care/stories/]
- (Vets Center) [http://next-content.staging.va.gov.s3-website-us-gov-west-1.amazonaws.com/abilene-vet-center]
7 changes: 4 additions & 3 deletions next.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@ const nextConfig = {
reactStrictMode: true,
swcMinify: true,
trailingSlash: true,
assetPrefix: isProd
? 'https://s3.us-gov-west-1.amazonaws.com/next-content.www.va.gov/'
: undefined,
assetPrefix: undefined,
// assetPrefix: isProd
// ? 'https://s3.us-gov-west-1.amazonaws.com/next-content.www.va.gov/'
// : undefined,
staticPageGenerationTimeout: 180, //arbitrary; 60 is default but it's too small
experimental: {
largePageDataBytes: 512 * 1000, // 512kb, is 128kb by default
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
"@actions/github": "^6.0.0",
"@department-of-veterans-affairs/component-library": "^42.2.2",
"@department-of-veterans-affairs/formation": "^11.0.12",
"@department-of-veterans-affairs/web-components": "^4.45.31",
"@department-of-veterans-affairs/web-components": "^10.0.2",
"@fortawesome/fontawesome-free": "^5.15.4",
"@octokit/rest": "^20.0.2",
"@storybook/react": "^8.0.5",
Expand Down
5 changes: 4 additions & 1 deletion playwright/tests/pressReleaseListing.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,10 @@ test.describe('pressReleaseListing', () => {
}) => {
await page.goto('/southern-nevada-health-care/news-releases')

const accessibilityScanResults = await makeAxeBuilder().analyze()
const accessibilityScanResults = await makeAxeBuilder()
.exclude('va-pagination')
.exclude('.usa-pagination__link')
.analyze()

expect(accessibilityScanResults.violations).toEqual([])
})
Expand Down
5 changes: 4 additions & 1 deletion playwright/tests/storyListing.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,10 @@ test.describe('Story Listing', () => {
makeAxeBuilder,
}) => {
await page.goto('/butler-health-care/stories')
const accessibilityScanResults = await makeAxeBuilder().analyze()
const accessibilityScanResults = await makeAxeBuilder()
.exclude('va-pagination')
.exclude('.usa-pagination__link')
.analyze()

expect(accessibilityScanResults.violations).toEqual([])
})
Expand Down
31 changes: 2 additions & 29 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1659,15 +1659,6 @@ __metadata:
languageName: node
linkType: hard

"@department-of-veterans-affairs/css-library@npm:^0.3.1":
version: 0.3.1
resolution: "@department-of-veterans-affairs/css-library@npm:0.3.1"
dependencies:
"@divriots/style-dictionary-to-figma": ^0.4.0
checksum: 550504db117697a9627c7b56b9c960a688aed380f0444b4accec3c6e123e6dd3f7f66359f532d80feba299ac4f8e5edea96d5980adbf962d13929467ab49539f
languageName: node
linkType: hard

"@department-of-veterans-affairs/css-library@npm:^0.8.1":
version: 0.8.4
resolution: "@department-of-veterans-affairs/css-library@npm:0.8.4"
Expand Down Expand Up @@ -1714,7 +1705,7 @@ __metadata:
languageName: node
linkType: hard

"@department-of-veterans-affairs/web-components@npm:10.0.2":
"@department-of-veterans-affairs/web-components@npm:10.0.2, @department-of-veterans-affairs/web-components@npm:^10.0.2":
version: 10.0.2
resolution: "@department-of-veterans-affairs/web-components@npm:10.0.2"
dependencies:
Expand All @@ -1733,24 +1724,6 @@ __metadata:
languageName: node
linkType: hard

"@department-of-veterans-affairs/web-components@npm:^4.45.31":
version: 4.60.0
resolution: "@department-of-veterans-affairs/web-components@npm:4.60.0"
dependencies:
"@department-of-veterans-affairs/css-library": ^0.3.1
"@stencil/core": ^2.19.2
aria-hidden: ^1.1.3
body-scroll-lock: ^4.0.0-beta.0
classnames: ^2.3.1
intersection-observer: ^0.12.0
peerDependencies:
"@department-of-veterans-affairs/formation": ^10.1.2
i18next: "*"
i18next-browser-languagedetector: "*"
checksum: 4b46a4d85cdcb55d5ae14ff4d64658fe8f5a87e2ed1a91e40f24a99c0798235e50f4d6ee7eeca6c98d3b0bfd6953e7c0c73e50d8499eb4fdc760518962889de0
languageName: node
linkType: hard

"@discoveryjs/json-ext@npm:^0.5.3":
version: 0.5.7
resolution: "@discoveryjs/json-ext@npm:0.5.7"
Expand Down Expand Up @@ -13234,7 +13207,7 @@ __metadata:
"@axe-core/playwright": ^4.8.2
"@department-of-veterans-affairs/component-library": ^42.2.2
"@department-of-veterans-affairs/formation": ^11.0.12
"@department-of-veterans-affairs/web-components": ^4.45.31
"@department-of-veterans-affairs/web-components": ^10.0.2
"@faker-js/faker": ^8.4.1
"@fortawesome/fontawesome-free": ^5.15.4
"@next/env": ^14.1.0
Expand Down

0 comments on commit 455164e

Please sign in to comment.