switch idp for regression test to login-gov

[TylerGuerrero-va]

Draft PR for changing IDP for the regression tests for SAML-Proxy to Login-Gov for better stability

1. Two of the test's 'ICN Errors' and 'modify' are currently failing right now

• With The 'ICN Errors' test its failing right now in the sandbox env but not the dev env. In sandbox its still able to get an access token and redirect the url even when using the user: [email protected] with the faulty ICN number, I did a manually test with Postman with that user in the dev env and did get the correct output, the expected Match Error page but in sandbox I am able to get the access token and it executes the redirect, so not sure why there is different behavior depending on the environment, Going to do further poking around to see what's going on with mpi

• The 'modify' test I am still trying to figure out why its failing

2. Link to sh file with export values to run the regression test locally: keybase://team/lighthouse_pivot/configs/saml-proxy/regression-test-envs.sh

3. Added the new env vars to the param store to align with the regression tests, kept the old idme ones for history but added the new login-gov ones: SAML-proxy param store

[crolarlibertyva]

Works as well as the previous ID me tests used to work. Maybe will try to recover the old 043 user for login.gov. I think that account still exists.

Still items to finish

[crolarlibertyva]

Before you can move this from draft, you need to align this with the new environment variables.

• https://github.com/department-of-veterans-affairs/lighthouse-saml-proxy/blob/API-38828-regression-tests-login-gov/cicd/buildspec-deploy.yml

[crolarlibertyva]

The Makefile needs updating too.

• lighthouse-saml-proxy/Makefile

  Lines 106 to 118 in d69c60a

  	regression:
  	@:$(call check_defined, IMAGE, IMAGE variable should be saml-proxy-tests)
  	docker run \
  	-v "/var/run/docker.sock:/var/run/docker.sock" \
  	--rm $(REPOSITORY)/$(NAMESPACE)/$(IMAGE):$(TAG) \
  	--saml-proxy-url=$(SAML_PROXY_URL) \
  	--client-id=$(CLIENT_ID) \
  	--idp=$(IDP) \
  	--authorization-url=$(AUTHORIZATION_URL) \
  	--user-password=$(USER_PASSWORD) \
  	--valid-user=$(VALID_USER_EMAIL) \
  	--icn-error-user=$(ICN_ERROR_USER_EMAIL)
  	--regression-test-timeout=$(REGRESSION_TEST_TIMEOUT)

[crolarlibertyva]

The entrypoint_test.sh needs adjusting as well.

Changes incorporated

[mwise-va]

• Tested locally, all test passing but modify test

      ✓ Happy Path (12799 ms)
      ✓ ICN Error (11394 ms)
      ✓ Replay (12419 ms)
      ✓ Empty SSO (2738 ms)
      ✓ Empty Assertion Response (2708 ms)
      ✓ 404 (2731 ms)
      ✕ modify (71101 ms)

• Double checked Parameter Store values and they look good