API-37717 IDP Metadata loads from Config as Fallback #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmweisz
reviewed
Jul 12, 2024
johnmweisz
reviewed
Jul 12, 2024
|
Bug ticket to address |
johnmweisz
reviewed
Jul 18, 2024
johnmweisz
approved these changes
Jul 18, 2024
crolarlibertyva
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make the retrieving and loading of IDP metadata more stable prior application start up, saml-proxy will first try to make an http request to retrieve IDP metadata before application start up. If that fails, then saml-proxy will pull the IDP metadata from configs.
Related Issue
https://jira.devops.va.gov/browse/API-37717