API-36203 banner data model #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
johnmweisz
reviewed
Jul 2, 2024
|
Comments addressed |
johnmweisz
reviewed
Jul 8, 2024
mwise-va
reviewed
Jul 9, 2024
johnmweisz
reviewed
Jul 9, 2024
mwise-va
reviewed
Jul 9, 2024
johnmweisz
reviewed
Jul 9, 2024
| try { | ||
| const key = this.generateKey(banner.id); | ||
| const value = JSON.stringify(banner); | ||
| const ttl = 604800; |
There was a problem hiding this comment.
Just a note, but thinking about this more ttl will end up being set to match the endTime. Can be updated in the next phase.
johnmweisz
approved these changes
Jul 9, 2024
mwise-va
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a data model and accessor class for the saml proxy banner. The banner.js represents the banner data model with banner parameters. And the BannerService implements the CRUD operations for banners in a Redis store.
Link to Jira: https://jira.devops.va.gov/browse/API-36203