API-37743 Address Dependabot Findings #489
Conversation
| "jest": "^29.6.1", | ||
| "puppeteer": "^17.1.3", | ||
| "puppeteer": "^22.12.1", |
There was a problem hiding this comment.
that's a big puppeteer change, did we test this in the container or at least with the version of chrome driver being downloaded in the container?
There was a problem hiding this comment.
Tested locally with npm test after making the changes.
There was a problem hiding this comment.
Had docker-compose up -d redis running and used this to run saml-proxy npm run-script start-dev
There was a problem hiding this comment.
you tested inside the docker test container?
There was a problem hiding this comment.
I don't think it will fully work on the Mac but you should at least see puppeteer connect to chrome api correctly
There was a problem hiding this comment.
Tried to build the test container locally on my Mac and it does not build. I think the not being able to build part is unrelated to these changes, and mac just struggles with building this test image.
Description
This PR addresses lighthouse-saml-proxy Dependabot findings - https://github.com/department-of-veterans-affairs/lighthouse-saml-proxy/security/dependabot
Related Issue(s)
https://jira.devops.va.gov/browse/API-37743