Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vebt 885 - update gibct institutions controller to handle combined name and location searches #1272

Merged
merged 10 commits into from
Dec 23, 2024

Conversation

GcioGregg
Copy link
Contributor

Description

In the future, the front end will allow users to combine name and location in a single search. This updates the gibct institution controller to handle that search scenario while being backwards compatible with name only and location only searches.

Original issue(s)

vebt-885

As a...

VEBT Developer

I want…

To build the Search By Name section of the CT redesign

So that…

CT redesign work can be completed

Acceptance Criteria

User can search for a name, a location, or both
School, employer or training program & city, state or postal code are both *REQUIRED fields. 

Technical Details:

Dependencies:

Collaborate with EDM to utilize one feature toggle
BE will need the URL parameters for the data call

Testing done

Developer user testing, rspec & rubocop tests pass.

Screenshots

Search By Name

Acceptance criteria

  • Legacy name only and location only searches in comparison tool work as expected.

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@GcioGregg GcioGregg requested a review from a team as a code owner December 23, 2024 20:52
@GcioGregg GcioGregg merged commit 6f29037 into master Dec 23, 2024
4 checks passed
@GcioGregg GcioGregg deleted the vebt-885 branch December 23, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants