Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-4748 redirect editors from admin #862

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

PhilipDeFraties
Copy link
Collaborator

@PhilipDeFraties PhilipDeFraties commented Apr 25, 2024

JIRA issue link

https://agile6.atlassian.net/browse/DM-4748

Description - what does this code do?

  • add redirect_editor_from_admin_dashboard method to ApplicationController, call as before_action for activeadmin requests

Testing done - how did you test it/steps on how can another person can test it

  1. As a user with a page_group_editor role, try and access the admin dashboard
  2. Verify you are redirected to the Community Editor Portal

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@PhilipDeFraties PhilipDeFraties marked this pull request as ready for review April 25, 2024 22:37
@PhilipDeFraties PhilipDeFraties self-assigned this Apr 25, 2024
@PhilipDeFraties PhilipDeFraties merged commit 268f648 into master Apr 25, 2024
5 of 6 checks passed
@PhilipDeFraties PhilipDeFraties deleted the dm-4748-redirect-editors-from-admin branch April 25, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants