Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added letter generator release notes #22

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

amizan8653-va
Copy link

Addresses API-19709

  • Just adding a single bullet point "The addition of the Benefits Summary Dependent Letter, used by the VA Mobile App, which contains the dependent user's benefit information including the claim number and an array of military service objects such as a history of the Veteran's most recent periods of service (up to three) and disability status." from this URL:
    https://community.max.gov/pages/viewpage.action?pageId=2291136579

@amizan8653-va amizan8653-va requested a review from a team as a code owner October 14, 2022 20:11
@amizan8653-va amizan8653-va temporarily deployed to development October 14, 2022 20:11 Inactive
@github-actions
Copy link

These changes have been pushed to dev.

@darduda
Copy link
Contributor

darduda commented Oct 18, 2022

Hi @amizan8653-va --I'm only seeing an empty file. Should I be looking in a different repo for the release notes file changed?

@amizan8653-va amizan8653-va temporarily deployed to development October 19, 2022 14:33 Inactive
@github-actions
Copy link

These changes have been pushed to dev.

@amizan8653-va
Copy link
Author

Hi @amizan8653-va --I'm only seeing an empty file. Should I be looking in a different repo for the release notes file changed?

Ah my bad... I just updated my PR to contain the release note.

@darduda
Copy link
Contributor

darduda commented Oct 19, 2022

thanks, @amizan8653-va! One more question for you. Is this the entire release note, or is this bullet being added to a different release note? (I might want to change how it reads if it's standing alone)

@amizan8653-va
Copy link
Author

thanks, @amizan8653-va! One more question for you. Is this the entire release note, or is this bullet being added to a different release note? (I might want to change how it reads if it's standing alone)

No problem, and this is the entire release note. Feel free to make whatever changes you feel are appropriate :)

made some changes--let me know if you have any questions! I'm also wondering if we need to mention the letter is used by the VA Mobile app. Will it always be used by that app, and only that app? If not, we could just say this: 

We've added the Benefits Summary Dependent Letter to the VA Letter Generator API. This letter includes the following information about a dependent's benefits: 
 - Claim number
 - Military service objects, such as the Veteran's disability status and up to 3 of their most recent periods of service
@darduda darduda temporarily deployed to development October 20, 2022 17:52 Inactive
@github-actions
Copy link

These changes have been pushed to dev.

Copy link
Contributor

@darduda darduda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some changes to the file and left a comment re: VA Mobile app--let me know if you have any questions.

darduda
darduda previously approved these changes Oct 21, 2022
@Shoaib-VA Shoaib-VA temporarily deployed to development December 22, 2022 15:49 — with GitHub Actions Inactive
@github-actions
Copy link

These changes have been pushed to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants