Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows to post news #125

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add workflows to post news #125

wants to merge 18 commits into from

Conversation

andresriveratoro
Copy link
Contributor

No description provided.

@andresriveratoro andresriveratoro requested a review from a team as a code owner March 26, 2024 15:10
Copy link
Collaborator

@gileswells gileswells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change / question with the duplicate update error condition but overall looks good to me. Of course this needs to get into the main branch before we can really start testing its functionality.

issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: 'If this release note was merged to the `main` branch on another PR, you will need to reach out to [Team Okapi](https://lighthouseva.slack.com/archives/C01931CFMTQ) to remove the copy that remains on the previous date.'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to reference it being news, not release notes. Also the ending of this error talks about the date. Are we doing any deduplication of news posts on the LPB side? Would this error ever hit?

@andresriveratoro andresriveratoro marked this pull request as draft March 28, 2024 16:45
@andresriveratoro andresriveratoro marked this pull request as ready for review March 29, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants