Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-18521 Remove tech debt detail-page.html #2370

Merged
merged 5 commits into from
Dec 4, 2024
Merged

VACMS-18521 Remove tech debt detail-page.html #2370

merged 5 commits into from
Dec 4, 2024

Conversation

chriskim2311
Copy link
Contributor

@chriskim2311 chriskim2311 commented Nov 30, 2024 •
edited
Loading

Summary

Remove tech debt surrounding the analytics changes in ticket 18521

Related issue(s)

department-of-veterans-affairs/va.gov-cms#18521

Testing done

Tested content build working locally

Screenshots

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/18521-ga-analytics December 2, 2024 20:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/18521-ga-analytics December 2, 2024 23:56 Inactive
@chriskim2311 chriskim2311 marked this pull request as ready for review December 3, 2024 20:05
@chriskim2311 chriskim2311 requested review from a team as code owners December 3, 2024 20:05
eselkin
eselkin approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to remove unused content. LGTM

SnowboardTechie
SnowboardTechie approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to have things cleaned up 🙌🏻

@chriskim2311 chriskim2311 merged commit 11032f3 into main Dec 4, 2024
24 checks passed
@chriskim2311 chriskim2311 deleted the 18521-ga-analytics branch December 4, 2024 18:40
timcosgrove pushed a commit that referenced this pull request Dec 4, 2024
@chriskim2311 @timcosgrove
VACMS-18521 Remove tech debt detail-page.html (#2370)
ca488cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnowboardTechie SnowboardTechie SnowboardTechie approved these changes

@eselkin eselkin eselkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskim2311 @eselkin @SnowboardTechie @va-vfs-bot