-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds entry for supply reordering app under /my-health #2354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I don't recall if appName
in the content-build registry or the one in the app manifest is used for the document title, but wanted to say something in case "Health Care Supply Reordering" isn't intended to be the user-facing title for the SPA. I could be wrong on multiple accounts.
@dcloud After looking through the following files, I believe the
At the moment, I've set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entry looks good. I tried testing the new supply reordering app locally and looks like the appName in this content-build registry is used for the document title.
…/mhv-supply-reordering/manifest.json
* Adds entry for supply reordering app under /my-health * Set appName and productId to valuess in vets-website/src/applications/mhv-supply-reordering/manifest.json
Summary
/my-health
pathRelated issue(s)
Make application available in lower environments : Supply Reordering va.gov-team#97137
Testing done
/my-health/order-supplies
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?