Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds entry for supply reordering app under /my-health #2354

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

radavis
Copy link
Contributor

@radavis radavis commented Nov 14, 2024

Summary

  • Adds entry for supply reordering app under the /my-health path

Related issue(s)

Testing done

  • Verified that the local changes allow the react application to be served at /my-health/order-supplies

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/cartographers/supply-reordering November 14, 2024 14:42 Inactive
@radavis radavis requested a review from carlosfelix2 November 14, 2024 14:42
Copy link
Contributor

@dcloud dcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

I don't recall if appName in the content-build registry or the one in the app manifest is used for the document title, but wanted to say something in case "Health Care Supply Reordering" isn't intended to be the user-facing title for the SPA. I could be wrong on multiple accounts.

@radavis
Copy link
Contributor Author

radavis commented Nov 14, 2024

@dcloud After looking through the following files, I believe the appName within the content-build registry determines the page title (unless overridden by the react app). Will have to investigate/experiment to know for sure.

  • src/site/stages/build/plugins/create-react-pages.js
  • src/site/includes/header.html
  • src/site/includes/metatags.drupal.liquid

At the moment, I've set vagovprod: false so that we're only deploying to lower environments. Thanks for the info!

Copy link

@nichia nichia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entry looks good. I tried testing the new supply reordering app locally and looks like the appName in this content-build registry is used for the document title.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/cartographers/supply-reordering December 3, 2024 15:28 Inactive
@radavis radavis marked this pull request as ready for review December 3, 2024 15:34
@radavis radavis requested review from a team as code owners December 3, 2024 15:34
@radavis radavis merged commit 4aed56f into main Dec 4, 2024
24 checks passed
@radavis radavis deleted the cartographers/supply-reordering branch December 4, 2024 18:44
timcosgrove pushed a commit that referenced this pull request Dec 4, 2024
* Adds entry for supply reordering app under /my-health

* Set appName and productId to valuess in vets-website/src/applications/mhv-supply-reordering/manifest.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants