Rebasing PR #2276

davidmpickett · 2024-09-17T19:18:48Z

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

(Summarize the changes that have been made to the platform)
(If bug, how to reproduce)
(What is the solution, why is this the solution)
(Which team do you work for, does your team own the maintenance of this component?)
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Link to ticket created in va.gov-team repo
department-of-veterans-affairs/va.gov-team#0000
Link to previous change of the code/bug (if applicable)
department-of-veterans-affairs/vets-website#0000
Link to epic if not included in ticket
department-of-veterans-affairs/va.gov-team#0000

Testing done

Describe what the old behavior was prior to the change
Describe the steps required to verify your changes are working as expected
Describe the tests completed and the results
_Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

	Before	After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated (link to documentation *if necessary)
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* VACMS 17954 - remove italics * move to p instead of div

* filterBy status:true services * fix accordion labeling ids * remove debugging

* Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div

* update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]>

* added feedback button to checklist drupal template * moved element to under back-to-top element

* creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify

Signed-off-by: Micah Chiang <[email protected]>

* Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]>

Signed-off-by: Micah Chiang <[email protected]>

* Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]>

* VC Banner image

Co-authored-by: Rachel <[email protected]>

* VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json

* adds svgs for nav icons * correct svg icon

[Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352)

Co-authored-by: Chad Chotikasatien <[email protected]>

* Update SCO registry.json route * vagovprod to true for sco page * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> * VEBT-423 Update SCO registry.json route to match prod (#2245) * Update SCO registry.json route * Update registry.json for sco url * Making separate PR * Fix to breadcrumb padding on certain drupal pages. (#2241) * Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div * Turn on production flag for rollout (#2246) * update web-components (#2249) * update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> * Medallia - Add feedback button to checklist page layout (#2247) * added feedback button to checklist drupal template * moved element to under back-to-top element * VACMS 18909 KISS autosuggest data for services from taxonomies (#2248) * creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify * bump web components (#2250) Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> * #vebt-470 #removing 22-1990n entry in registry.json --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: GovCIOLiz <[email protected]> Co-authored-by: Andrew Steele <[email protected]> Co-authored-by: Kevin Duensing <[email protected]> Co-authored-by: Micah Chiang <[email protected]> Co-authored-by: Aubrey Arcangel <[email protected]> Co-authored-by: Eli Selkin <[email protected]> Co-authored-by: GovCIOLiz <[email protected]> Co-authored-by: Chad Chotikasatien <[email protected]>

…2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag

va-vfs-bot

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

Note:

Font Awesome is deprecated. Please use va-icon instead. For more information, visit the migration documentation: Migrate from font awesome to va-icon

va-vfs-bot · 2024-09-17T19:19:23Z

src/site/components/va_related_form.drupal.liquid

+      lang="{{ vaForm.fieldVaFormLanguage }}"
+    >
+      {% assign translatedDownloadText = vaForm.fieldVaFormLanguage | deriveLanguageTranslation: 'downloadVaForm', vaForm.fieldVaFormNumber %}
+      <va-icon class="vads-u-margin-right--0p5" icon="file_download" size="3"></va-icon>


va-vfs-bot · 2024-09-17T19:19:23Z

src/site/components/va_related_form.drupal.liquid

+    data-form-number="{{ vaForm.fieldVaFormNumber }}"
+    lang="{{ vaForm.fieldVaFormLanguage }}"
+    >
+      <va-icon


va-vfs-bot · 2024-09-17T19:19:23Z

src/site/layouts/va_form.drupal.liquid

+              lang="{{ fieldVaFormLanguage }}"
+            >
+              {% assign translatedDownloadText = fieldVaFormLanguage | deriveLanguageTranslation: 'downloadVaForm', fieldVaFormNumber %}
+              <va-icon class="vads-u-margin-right--0p5" icon="file_download" size="3"></va-icon>


va-vfs-bot · 2024-09-17T19:19:24Z

src/site/layouts/va_form.drupal.liquid

-          {% assign translatedDownloadText = fieldVaFormLanguage | deriveLanguageTranslation: 'downloadVaForm', fieldVaFormNumber %}
-          {{ translatedDownloadText }} (PDF)
-        </a>
+              <va-icon


eselkin and others added 27 commits August 18, 2024 23:21

VACMS 17954 - remove italics from common conditions (#2238)

62f23ba

* VACMS 17954 - remove italics * move to p instead of div

VACMS 16362: Make only published Vet Center Services display (#2243)

b52f88c

* filterBy status:true services * fix accordion labeling ids * remove debugging

Adding arrow_circle_right to sprite sheet (#2244)

3abda5d

Fix to breadcrumb padding on certain drupal pages. (#2241)

2dba5ac

* Fix to breadcrumb padding on certain drupal pages. * Adding row back * Removing another un-needed class * Adding padding to containing div

Turn on production flag for rollout (#2246)

edf86fe

update web-components (#2249)

74b46bb

* update web-components Signed-off-by: Micah Chiang <[email protected]> * bump version Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]>

Medallia - Add feedback button to checklist page layout (#2247)

dfa9d90

* added feedback button to checklist drupal template * moved element to under back-to-top element

VACMS 18909 KISS autosuggest data for services from taxonomies (#2248)

4d737ff

* creates va-healthcare-services.json * remove spaces from JSONs * process the processed HTML to text * simplify

bump web components (#2250)

4cfa31d

Signed-off-by: Micah Chiang <[email protected]>

bump web-components (#2258)

ea6009c

Signed-off-by: Micah Chiang <[email protected]>

direct links to hashreference of taxonomy name in facility (#2262)

9aa7235

VACMS 18711 - vet center banner image (#2251)

1f36beb

* VC Banner image

Add entry for Benefit Eligibility Questionnaire (#2170)

3251a54

update FMP name (#2257)

9abb220

Co-authored-by: Rachel <[email protected]>

VACMS-18876 Fix breadcrumbs on checklist pages (#2266)

29eec78

VEBT-468 remove 1990E from registry.json (#2260)

4eb4763

* VEBT-468 Remove 1990e from production. * VEBT-468 remove 1990E from registry.json

Add navigation svg icons to site/img directory (#2237)

8347d5b

* adds svgs for nav icons * correct svg icon

remove custom event (#2263)

9718327

[ARF-87799] Remove 21a (#2269)

9c4b3f1

[Corresponding `vets-website` PR](department-of-veterans-affairs/vets-website#31352)

#vebt-469 remove 1990s from registry.json (#2261)

fbef2aa

Co-authored-by: Chad Chotikasatien <[email protected]>

add sign-in-changes app to registry (#2271)

7e5de71

Updating web-components version to latest (#2272)

cfaea0d

wrapping (#2268)

6ecc046

VACMS-18855 Add Find Forms download modal back to form detail page (#…

fe16835

…2239) * VACMS-18855 Add Find Forms download modal back to form detail page * adding ID to container * Add feature flag * finishing up feature flag

davidmpickett requested review from a team as code owners September 17, 2024 19:18

davidmpickett merged commit 835fe67 into VACMS-18931-manila Sep 17, 2024
1068 of 1156 checks passed

va-vfs-bot reviewed Sep 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rebasing PR #2276

Rebasing PR #2276

davidmpickett commented Sep 17, 2024

va-vfs-bot left a comment

va-vfs-bot Sep 17, 2024

va-vfs-bot Sep 17, 2024

va-vfs-bot Sep 17, 2024

va-vfs-bot Sep 17, 2024

Rebasing PR #2276

Rebasing PR #2276

Conversation

davidmpickett commented Sep 17, 2024

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

va-vfs-bot left a comment

Choose a reason for hiding this comment

Icon found

What you can do

Note:

va-vfs-bot Sep 17, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 17, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 17, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 17, 2024

Choose a reason for hiding this comment