Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16952 VAMC System pages web components #2092

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

randimays
Copy link
Contributor

@randimays randimays commented May 20, 2024

Summary

Add v1 and v3 web components to VAMC system pages where possible. Converts the "See all (locations/stories/events)" buttons to active links.

Related issue(s)

Testing done

Tested locally on /boston-health-care and /minneapolis-health-care.

Screenshots

See all (locations/stories/events) to active link

Locations

Screenshot 2024-05-17 at 1 47 07 PM Screenshot 2024-05-17 at 1 47 03 PM

Stories

Screenshot 2024-05-17 at 2 08 34 PM Screenshot 2024-05-22 at 10 15 12 AM

Events

Screenshot 2024-05-22 at 10 14 49 AM Screenshot 2024-05-22 at 10 15 20 AM
"Manage your health online" icons

Desktop

Screenshot 2024-05-17 at 1 46 22 PM

Mobile

Screenshot 2024-05-22 at 10 25 47 AM

DOM

Screenshot 2024-05-17 at 1 46 51 PM
Full width banners

Desktop

Screenshot 2024-05-22 at 10 29 59 AM

Mobile

Screenshot 2024-05-22 at 10 30 05 AM

DOM

Screenshot 2024-05-22 at 10 24 32 AM
Back to top

Desktop

Screenshot 2024-05-22 at 10 32 40 AM

Mobile

Screenshot 2024-05-22 at 10 32 32 AM

DOM

Screenshot 2024-05-22 at 10 32 48 AM
Related links

Desktop

Screenshot 2024-05-22 at 10 36 10 AM

Mobile

Screenshot 2024-05-22 at 10 36 42 AM

DOM

Screenshot 2024-05-22 at 10 36 34 AM

@randimays randimays force-pushed the 16952-vamc-system-wc branch 2 times, most recently from 0e01acb to f8d758a Compare May 22, 2024 15:09
@randimays randimays changed the title VACMS-19695 VAMC System pages web components VACMS-19692 VAMC System pages web components May 22, 2024
@randimays randimays force-pushed the 16952-vamc-system-wc branch from f8d758a to 0837660 Compare May 22, 2024 15:43
@randimays randimays changed the title VACMS-19692 VAMC System pages web components VACMS-16952 VAMC System pages web components May 22, 2024
@randimays randimays marked this pull request as ready for review May 22, 2024 19:14
@randimays randimays requested review from a team as code owners May 22, 2024 19:14
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laflannery
Copy link

@randimays My only question is if the Stories link can be a va-link component - Unless this will get changed in the separate stories ticket (because Events has changed so perhaps that's how that happened already)?

@randimays
Copy link
Contributor Author

@laflannery Is this the Stories link you're referring to? If so, that one is a va-link on my end.

Screenshot 2024-05-23 at 10 10 07 AM Screenshot 2024-05-23 at 10 10 00 AM

@laflannery
Copy link

Yep, that's it - I just didn't see a screenshot for it - sorry about that, Approved!

@randimays
Copy link
Contributor Author

@laflannery My apologies for missing that screenshot! Thank you :)

@randimays randimays merged commit 04dda37 into main May 23, 2024
25 of 27 checks passed
@randimays randimays deleted the 16952-vamc-system-wc branch May 23, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants