Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17095 spotlight converted to card #2076

Merged
merged 2 commits into from
May 9, 2024
Merged

17095 spotlight converted to card #2076

merged 2 commits into from
May 9, 2024

Conversation

jtmst
Copy link
Contributor

@jtmst jtmst commented May 9, 2024

Summary

  • updates spotlight components to use VR cards in vba template
  • updates classes to match desired styling

Related issue(s)

department-of-veterans-affairs/va.gov-cms#17095

Testing done

  • local testing
    -test suites

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

image

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jtmst jtmst requested a review from a team as a code owner May 9, 2024 18:15
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/17095-vba-template-ds-v3 May 9, 2024 18:24 Inactive
@jilladams jilladams changed the title spotlight converted to card 17095 spotlight converted to card May 9, 2024
@eselkin
Copy link
Contributor

eselkin commented May 9, 2024

LGTM

@jtmst jtmst requested a review from laflannery May 9, 2024 19:16
Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just noting that Josh confirmed the additional spacing is actually CMS data

@jtmst jtmst merged commit e955ff7 into main May 9, 2024
24 checks passed
@jtmst jtmst deleted the 17095-vba-template-ds-v3 branch May 9, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants