VACMS-10940 Consolidate reusable and page-specific Q&As on CLPs #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
10940-qa-consolidate
branch
from
b38d48e to
a2988c1
Compare
chriskim2311
approved these changes
Jun 11, 2024
|
@randimays I am realizing we discussed the header but not the intro field and so it seems to be handled differently:
Was this an intentional difference in the display? Ideally I think this should show directly under the H2 because if we are combining the Q&As then the intro should apply to all of these as well. But let me know if that is not possible and I can create a new ticket for this to determine behavior based on technical feasibility. |
|
@laflannery I didn't add introductions to all of the CLPs for testing as that section is also optional. The fraud, action center, and flu CLPs have intros but the trust one does not. I'll add the intro under the header (if it exists) and get this updated! |
|
@laflannery This is ready for your review please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None of our production Campaign Landing Pages use the Reusable Q&A feature yet, but when they do: we want the reusable Q&As that do not have a header to be combined under "Frequently Asked Questions." When the Reusable Q&A does have a header, we should see "Frequently Asked Questions" first with its accordions, and the header for the Reusable Q&As second with its accordions.
Related issue(s)
Testing done
Tested locally at:
Screenshots
Note: some screenshots are back-to-back. Ignore any vertical spacing weirdness as it's probably just a "seam" between screenshots.
Standard reusable Q&As with header
URL: https://web-fw8iwfgw7bk58wghnmcqhga5gprkrgrv.demo.cms.va.gov/initiatives/protecting-veterans-from-fraud
CMS data
Desktop view
Mobile view
Standard reusable Q&As without header
URL: https://web-fw8iwfgw7bk58wghnmcqhga5gprkrgrv.demo.cms.va.gov/initiatives/veteran-trust-in-va/
CMS Data
Desktop view
Mobile view
Accordion reusable Q&As with header
URL: https://web-fw8iwfgw7bk58wghnmcqhga5gprkrgrv.demo.cms.va.gov/initiatives/veterans-experience-action-centers/
CMS Data
Desktop view
Mobile view
Accordion reusable Q&As without header
URL: https://web-fw8iwfgw7bk58wghnmcqhga5gprkrgrv.demo.cms.va.gov/initiatives/covid-flu/
CMS Data
Desktop view
Mobile view