Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Service template update accordions to v3 #2014

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Apr 10, 2024

Summary

  • Updates va-accordion and va-accordion-item to uswds="true" for Health Service templates
  • Sitewide Facilities

Related issue(s)

Testing done

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

former- desktop
new- desktop
former- mobile
new- mobile

What areas of the site does it impact?

VAMC Health Service pages

Acceptance criteria

  • Accordion component has been updated to v3
  • Update and run existing test(s).
  • If additional tests are needed, stub a ticket to note this for future work.
  • Requires accessibility review

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

@eselkin
Copy link
Contributor Author

eselkin commented Apr 10, 2024

@laflannery waiting on Review Instance to work

Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I confirmed the changes on the review environment 👍

Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes in all supported browsers

@eselkin eselkin merged commit b77451e into main Apr 11, 2024
26 checks passed
@eselkin eselkin deleted the VACMS-16997-VAMC-HealthServices-template-update-v3 branch April 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants