VACMS-17057 Events detail page web component upgrades #1972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
17057-events-detail-wc
branch
from
6f4d026 to
bb0ee18
Compare
|
@randimays A few comments:
|
va-vfs-bot
reviewed
Mar 19, 2024
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
| <a class="va-js-share-link" href="https://www.facebook.com/sharer/sharer.php?href={{ hostUrl }}{{ entityUrl.path }}"> | ||
| <i aria-hidden="true" class="va-c-social-icon fab fa-facebook vads-u-margin-right--0p5" role="presentation"></i>Share on Facebook | ||
| </a> | ||
| <i aria-hidden="true" class="va-c-social-icon fab fa-facebook vads-u-margin-right--0p5" role="presentation"></i> |
| <a class="va-js-share-link" href="https://twitter.com/intent/tweet?text={{ title }}&url={{ hostUrl }}{{ entityUrl.path }}"> | ||
| <i aria-hidden="true" class="va-c-social-icon fab fa-twitter vads-u-margin-right--0p5" role="presentation"></i>Share on Twitter | ||
| </a> | ||
| <i aria-hidden="true" class="va-c-social-icon fab fa-twitter vads-u-margin-right--0p5" role="presentation"></i> |
chriskim2311
approved these changes
Mar 19, 2024
randimays
force-pushed
the
17057-events-detail-wc
branch
from
3f6194b to
081ee4e
Compare
randimays
force-pushed
the
17057-events-detail-wc
branch
from
081ee4e to
d260a78
Compare
randimays
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update individual event template with web components where they exist.
Related issue(s)
Testing done
Tested a couple of events pages locally:
/minneapolis-health-care/events/64415//outreach-and-events/events/53182/Screenshots
Online event link
See more events link
Show all times button
Add to calendar links inside accordion
More times accordion
Single add to calendar link
Acceptance criteria
Quality Assurance & Testing