Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-17188 Remaining Find Forms links fixes and accessibility fixes #1960

Merged
merged 1 commit into from
Mar 14, 2024
Merged

VACMS-17188 Remaining Find Forms links fixes and accessibility fixes #1960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 23 additions & 21 deletions src/site/layouts/va_form.drupal.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@
<i
aria-hidden="true"
class="fas fa-download fa-lg vads-u-margin-right--1 va-form-layout--remove-pointer-events"
role="presentation"
> </i>
{% assign translatedDownloadText = vaForm.entity.fieldVaFormLanguage | deriveLanguageTranslation: 'downloadVaForm', vaForm.entity.fieldVaFormNumber %}
{{ translatedDownloadText }} (PDF)
Expand All @@ -180,11 +179,12 @@
{% for vaFormLinkTeaser in fieldVaFormLinkTeasers %}
<li>
<h3 class="vads-u-font-size--h4">
<a
<va-link
disable-analytics
href="{{ vaFormLinkTeaser.entity.fieldLink.url.path }}"
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': '{{ vaFormLinkTeaser.entity.fieldLink.title | escape }}', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })">
{{ vaFormLinkTeaser.entity.fieldLink.title }}
</a>
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': '{{ vaFormLinkTeaser.entity.fieldLink.title | escape }}', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })"
text="{{ vaFormLinkTeaser.entity.fieldLink.title }}"
/>
</h3>
<p class="vads-u-margin--0">{{ vaFormLinkTeaser.entity.fieldLinkSummary }}</p>
</li>
Expand All @@ -193,41 +193,43 @@
{% comment %} The default related links if custom links aren't defined {% endcomment %}
<li>
<h3 class="vads-u-font-size--h4">
<a
<va-link
disable-analytics
href="/change-direct-deposit"
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Change your direct deposit information', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })">
Change your direct deposit information
</a>
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Change your direct deposit information', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })"
text="Change your direct deposit information"
/>
</h3>
<p class="vads-u-margin--0">Find out how to update your direct deposit information online for disability compensation, pension, or education benefits. </p>
</li>
<li>
<h3 class="vads-u-font-size--h4">
<a
<va-link
disable-analytics
href="/change-address"
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Change your address', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })">
Change your address
</a>
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Change your address', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })"
text="Change your address"
/>
</h3>
<p class="vads-u-margin--0">Find out how to change your address and other information in your VA.gov profile for disability compensation, claims and appeals, VA health care, and other benefits.</p>
</li>
<li>
<h3 class="vads-u-font-size--h4">
<a
<va-link
href="/records/get-military-service-records/"
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Request your military records, including DD214', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })">
Request your military records, including DD214
</a>
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Request your military records, including DD214', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })"
text="Request your military records, including DD214"
/>
</h3>
<p class="vads-u-margin--0">Submit an online request to get your DD214 or other military service records through the milConnect website.</p>
</li>
<li>
<h3 class="vads-u-font-size--h4">
<a
<va-link
href="/records/"
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Get your VA records and documents online', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })">
Get your VA records and documents online
</a>
onclick="recordEvent({ event: 'nav-linkslist', 'links-list-header': 'Get your VA records and documents online', 'links-list-section-header': '{{ linkTeasersHeader | escape }}' })"
text="Get your VA records and documents online"
/>
</h3>
<p class="vads-u-margin--0">Learn how to access your VA records, benefit letters, and documents online.</p>
</li>
Expand Down
12 changes: 7 additions & 5 deletions src/site/paragraphs/linkTeaser.drupal.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,13 @@
{% if header === "h3" %}
{% if link.title != empty %}
<h3 class="{{ headerClass }}">
<a href="{{link.url.path}}" class="vads-u-text-decoration--underline"
{% if linkTeaser.options["target"] %}target="{{ linkTeaser.options["target"] }}"{% endif %}
>
{{ link.title }}
</a>
<va-link
href="{{link.url.path}}"
text="{{ link.title }}"
{% if linkTeaser.options["target"] %}
target="{{ linkTeaser.options["target"] }}"
{% endif %}
/>
</h3>
{% endif %}
{% else %}
Expand Down
2 changes: 1 addition & 1 deletion src/site/paragraphs/lists_of_links.drupal.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<!-- See more articles link -->
{% if vaParagraph.entity.fieldLink.url.path %}
<li class="vads-u-padding-y--1">
<va-link active class="vads-u-text-decoration--none" href="{{ vaParagraph.entity.fieldLink.url.path }}" text="{{ vaParagraph.entity.fieldLink.title }}">
<va-link active href="{{ vaParagraph.entity.fieldLink.url.path }}" text="{{ vaParagraph.entity.fieldLink.title }}">
<i class="fa fa-chevron-right vads-u-padding-left--0p5 vads-u-font-size--sm" aria-hidden="true" role="presentation"></i>
</va-link>
</li>
Expand Down
Loading