Fixes Newsletter and the intro text which is not introtext in VBA it is Centralized Content #1924
Conversation
va-vfs-bot
temporarily deployed
to
master/main/VACMS-14933-centralized-content-VBA-fix
va-vfs-bot
temporarily deployed
to
master/main/VACMS-14933-centralized-content-VBA-fix
eselkin
changed the title
eselkin
changed the title
| @@ -823,6 +823,7 @@ module.exports = function registerFilters() { | |||
| }; | |||
|
|
|||
| liquid.filters.replace = (string, oldVal, newVal) => { | |||
| if (!string) return null; | |||
|
@eselkin I know you only added the newsletter link here but can we add |
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
|
@laflannery Added the |
|
@eselkin In the Get updates section for mobile, is it possible to evenly space all of the links? The Facebook and Twitter links look close together in this example. It should have the same spacing as VAMC Get updates sections. I'm unable to see the styling in your tugboat link, so can't see if this has already been addressed. My computer must be having some issues. |
|
@thejordanwood The funny thing is I took the Vet Center's component and copied it. I'll take a look at VAMC now to see if that's a better system. |
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
There was a problem hiding this comment.
Icon found
Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.
What you can do
Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.
|
@thejordanwood Restructured the spacing on the grid pieces in the Social updates section. It had been the same as the VAMC and Vet Center component, but because of the wording the spacing was off. This was because it wasn't guaranteed to be the same text since it can be changed by editors of the centralized. They should be cautious of changing the centralized text though, probably. |
|
@eselkin Thank you! This looks good to me. |
Summary
Related issue(s)
Testing done
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
Only VBA pages
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
View Cleveland Regional Benefit Office on tugboat: https://web-ihqrv6rby5lxlkn8zqdxf9u7lk1aplcp.demo.cms.va.gov/cleveland-va-regional-benefit-office/locations/cleveland-va-regional-benefit-office/