Vacms 16144 VAMC service location paragraphs - and merge VBA

[eselkin]

DO NOT MERGE - DEPENDS ON CMS PR-15622

Summary

• Takes existing VAMC service location paragraph, adds appointment information. Removes VBA service location paragraph and merges content. Reorganizes both to follow VBA order from designs. Improves reasons for showing or not showing content on the component.
• Sitewide Facilities
• Integration branch for VAMC, but coordinates with VBA

Related issue(s)

• relates to Front End: Update VAMC appointment information in Service Location va.gov-cms#16144
• blocked by VACMS-14683: Updating service locations paragraph va.gov-cms#15622

Testing done

• VAMC service locations were just inline with the accordions but the paragraphs were difficult to parse and now more information is added to the paragraph types (including appointment info, etc).
• VAMC still render as do VBA facilities for regional and facility services
• Added test for VAMC health service, non-clinical service, existing VBA service test this for compliance

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Desktop non-clinical

Desktop clinical

Desktop VBA. Some fields missing from the VBA query to populate appointments

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Acceptance Criteria

• Timing is coordinated with Drupal engineers
• Query is updated to remove these fields from VAMC Facility Service (health_care_local_health_service)
  • field_hservice_appt_intro_select
  • field_hservice_appt_leadin
  • field_online_scheduling_availabl
  • field_walk_ins_accepted
  • field_phone_numbers_paragraph
• Query is updated to add the fields from the Service Location paragraph.
  • Not sure what fields have already been added. This will give you the list of all the fields in the service location paragraph
• Template is updated to remove the deleted fields and add the new fields.
  • Walk-ins accepted is no longer showing.
  • Service Delivery options are showing.
  • For Appointments intro text, if Customize text is selected but no text is entered, nothing is shown (acts like Remove text was selected)
• Accordion elements are confirmed
• Merge the VBA and VAMC Facility and Regional Service Location paragraph type liquid templates.
• This ticket need to go into their own integration branch. (This is the integration branch and has Do not merge on it)
• Testing is completed as needed
• Design is reviewed (tag in PR)
• Accessibility is reviewed (tag in PR)

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

Error Handling

• Browser console contains no warnings or errors.
• Events are being sent to the appropriate logging solution
• Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

• Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

1. view VAMC non-clinical services at: https://web-pr15622-xptmfsnjoodldn85nzgkrgljqtfbz24b.ci.cms.va.gov/fayetteville-arkansas-health-care/medical-records-office/

2. view VAMC clinical services at: https://web-pr15622-xptmfsnjoodldn85nzgkrgljqtfbz24b.ci.cms.va.gov/washington-dc-health-care/locations/washington-va-medical-center/

Note: I am concerned about us displaying the "Appointments" header when there's really no appointment text like in Anesthesiology or Emergency Care

3. view VBA services at: https://web-pr15622-xptmfsnjoodldn85nzgkrgljqtfbz24b.ci.cms.va.gov/cleveland-va-regional-benefit-office/locations/cleveland-va-regional-benefit-office/

[va-vfs-bot]

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

[va-vfs-bot]

Icon found

Icons can be decorative, but sometimes they are used to convey meaning. If there are any semantics associated with an icon, those semantics should also be conveyed to a screen reader.

What you can do

Review the markup and see if the icon provides information that isn't represented textually, or wait for a VSP review.

[jilladams]

@maxx1128 : reminder re: review and I'm going to go ahead and ping Platform FE just for safety, since this needs to merge by EOD Monday if the CMS deploy goes well.

[jilladams]

@eselkin actually: should I wait til CI is passing?

[eselkin]

Platform likes to review only after tests pass, but since this is dependent on CMS merging SL it's probably ok to ping them now.

[jilladams]

ugh right, I keep forgetting that. Thank you!

[maxx1128]

One small concern to address before I think it's good.