16361 clp derivative #1858
Merged
16361 clp derivative #1858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randimays
force-pushed
the
16361-clp-derivative
branch
from
66a5865 to
d9c5316
Compare
chriskim2311
approved these changes
Jan 10, 2024
maxx1128
approved these changes
Jan 10, 2024
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a previous ticket (PR here, we updated the CLP landing page hero images to use a square crop rather than be a full-width banner. This included adding a hard-coded size to the image because the
CROPSQUAREderivative from Drupal was sending images through at <400px, and the design was closer to 500px. We got a new derivative created that sends the images back at 500px, so we can remove the hard-coded size and update the GraphQL query.Related issue(s)
Testing done
Tested and in Tugboat.
Full list of prod Campaign Landing Pages to verify in Tugboat:
Screenshots
This banner image does not appear on mobile/tablet sizes, so there are no screenshots of that here.
Before
Hard-coded image size
After
Image size coming from Drupal
