VACMS-15717: Change reusable Q&As header structure

[chriskim2311]

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

For this ticket we addressed header tags for accordions based on if we have a header title or not. There were multiple implementations of these reusable Q&As so we created tugboat content for each.

 FAQs
 Resources & Support
 Benefit Detail Pages
 CLPs

Related issue(s)

department-of-veterans-affairs/va.gov-cms#15717

Testing done

Tugboat Env: main-dyel3cg3kniaoc6nrizjhqazkfgueref.demo.cms.va.gov/

CLP: https://web-dyel3cg3kniaoc6nrizjhqazkfgueref.demo.cms.va.gov/initiatives/this-is-my-clp
FAQs: https://web-dyel3cg3kniaoc6nrizjhqazkfgueref.demo.cms.va.gov/resources/test-faq-page
Resources & Support: https://web-dyel3cg3kniaoc6nrizjhqazkfgueref.demo.cms.va.gov/resources/r-s-detail-page
Benefit Detail Pages: https://web-dyel3cg3kniaoc6nrizjhqazkfgueref.demo.cms.va.gov/benefits-detail

Screenshots

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

• Test Reusable Q&As across multiple content types.
• A11y review

Quality Assurance & Testing

• I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• Linting warnings have been addressed
• Documentation has been updated (link to documentation *if necessary)
• Screenshot of the developed feature is added
• Accessibility testing has been performed

[randimays]

LGTM!

[laflannery]

These look good, however, per discussion with with @chriskim2311 I think we may need to rethink/rework the CLP headers when we looked at this other ticket

[maxx1128]

This may be because I'm less familiar with this content, but it looks like some h2 headers appear near the bottom of most of the pages here. Is that intended or is the code not keeping them at h3 when it should be?

[laflannery]

@maxx1128 I don't understand the question? However I can tell you that this is fake content - does that help answer your question?

[maxx1128]

@laflannery My question is whether the circled headers should be h2 or h3 headers. The fact that it's fake data makes it harder for me to tell if them being h2s was purposeful or accidental.

[laflannery]

They should be H2s - I reviewed these pages previously and the header structure is now all correct, pending the comment I left before