Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vye folder build #1751

Merged
merged 2 commits into from
Oct 23, 2023
Merged

Vye folder build #1751

merged 2 commits into from
Oct 23, 2023

Conversation

jsimonVA
Copy link
Contributor

Description

Created file structure in vets-website for new application "verify-your-enrollment"

Pushing updated registry.json with new reference to verify your enrollment app

related vets-website PR - department-of-veterans-affairs/vets-website#26058

closes __
relates to __

Testing done & Screenshots

No testing other than making sure new app shows up in local environment. App does show.

QA steps

What needs to be checked to prove this works?

  • User can navigate to /education/verify-your-enrollment/
  • note- this is currently blank as it is a place holder.
    What needs to be checked to prove it didn't break any related things?
    n/a, nothing deleted only added new reference to new app
    What variations of circumstances (users, actions, values) need to be checked? n/a
  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)/ Github PR for vetswebsite has been linked
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@jsimonVA jsimonVA merged commit b2c66f1 into main Oct 23, 2023
21 checks passed
@jsimonVA jsimonVA deleted the vye-folder-build branch October 23, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants