Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-14307 Contain Veteran banner in main element #1746

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Oct 16, 2023

Description

The div that contains the Veteran portraits on Benefits Hub landing pages (i.e. /health-care) is not contained by a landmark (the <main> element). This moves it into that element.

Tugboat to review: https://web-1wtvtqpercm3v5ybkwhzw7ai8277jd1u.demo.cms.va.gov/health-care/

Testing done & Screenshots

Screenshot 2023-10-16 at 12 23 09 PM

Screenshot 2023-10-16 at 12 23 00 PM

Screenshot 2023-10-16 at 12 21 19 PM

Screenshot 2023-10-16 at 12 21 06 PM

QA steps

  1. Navigate to /health-care
  2. Inspect the Veteran banner at the bottom of the page
  3. Confirm the .veteran-banner element is contained within main
  4. Run the axe DevTools scan (Chrome plugin)
  5. Validate that the All page content should be contained by landmarks category either doesn't exist or does not contain veteran-banner if it does exist

Acceptance criteria

  • As a screen reader user, I want to navigate the content of the page by landmark regions.

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laflannery
Copy link

Confirmed that the error is no longer being flagged by axe and the HTML looks good!

@randimays randimays merged commit 0fffd8a into main Oct 17, 2023
24 checks passed
@randimays randimays deleted the 14307-landmarks branch October 17, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants