Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-15414 Add Cypress tests for homepage #1742

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

randimays
Copy link
Contributor

@randimays randimays commented Oct 10, 2023

Description

vets-website had an outdated homepage test that was reviewing /new-home-page. Since we released the new home page in June 2023, we've added a redirect from /new-home-page to /, causing this Cypress test to fail. In order to add value by testing our existing home page, Cypress tests must be added in content-build. This is because vets-website does not have content-build data available in its CI, so all that can be tested there is the header and footer.

Ticket: department-of-veterans-affairs/va.gov-cms#15414

Testing done & Screenshots

Cypress test passes locally.

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM great work!

@randimays randimays merged commit 349221c into main Oct 10, 2023
24 checks passed
@randimays randimays deleted the 15414-add-cypress branch October 10, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants