Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH36 Forn Name Change Cleanup #1720

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

DLarson-Oddball
Copy link
Contributor

@DLarson-Oddball DLarson-Oddball commented Sep 26, 2023

Description

relates to: department-of-veterans-affairs/vets-website#25875

Testing done & Screenshots

Tested local environment and confirmed app 28-8832 is removed and 25-8832 continues to stay live with the proper content.

QA steps

Test w/ department-of-veterans-affairs/vets-website#25875

What needs to be checked to prove this works?

  • Ensure careers-employment/education-and-career-counseling/apply-career-guidance-form-28-8832 does not load
  • Ensure careers-employment/education-and-career-counseling/apply-career-guidance-form-25-8832 still loads correctly
    What needs to be checked to prove it didn't break any related things?
    See above
    What variations of circumstances (users, actions, values) need to be checked?

Acceptance criteria

  • [ ]

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

Copy link
Contributor

@Midge-dev Midge-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DLarson-Oddball DLarson-Oddball merged commit 5304f66 into main Oct 10, 2023
24 checks passed
@DLarson-Oddball DLarson-Oddball deleted the 62663-ch36-form-name-change-cleanup branch October 10, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants