VACMS-14910: Add unique identifier to va-accordion-item id for healh services #1713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laflannery This PR is ready for your review |
maxx1128
approved these changes
Sep 19, 2023
|
Approved - confirmed axe is no longer reporting dup IDs, Anchor links in On this page component are still working and deep linking is working properly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On the health services page we have
h2headings with the same id as the accordion id's. This change will add a prefix ofitem-to the va-accordion items. Allowing for deep linking to these accordions and not breaking the headerOn this Pagefunctionality.Testing done & Screenshots
/boston-health-care/health-services/#item-primary-careQA steps
Verify that deep-linking works and that there are no identical ids on the page specifically the headers and va-accordion-items.
Acceptance criteria