Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buttons -> action links on facility and main locations pages #1708

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Sep 11, 2023

Description

closes department-of-veterans-affairs/va.gov-cms#14928

Testing done & Screenshots

Changed the links that looked like buttons in facility health services pages and main buttons to action links.

Before (health service location):
Screenshot 2023-09-11 at 4 22 16 PM

After (health service location):
Screenshot 2023-09-11 at 4 21 58 PM

Before (main location page for area)
Screenshot 2023-09-11 at 4 23 36 PM

After (main location page for area)
Screenshot 2023-09-11 at 4 23 54 PM

QA steps

  1. Go to
    1. http://455d26b70e26984d0cecdfec5b747475.review.vetsgov-internal/boston-health-care/locations/
    2. http://455d26b70e26984d0cecdfec5b747475.review.vetsgov-internal/boston-health-care/locations/jamaica-plain-va-medical-center/
    3. http://455d26b70e26984d0cecdfec5b747475.review.vetsgov-internal/boston-health-care/health-services/
  2. Then validate Acceptance Criteria from issue

Acceptance criteria

  • The top tasks links use the Design component for action links and meet accessibility best practices.
  • Accessibility Lead review

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@eselkin eselkin marked this pull request as ready for review September 12, 2023 17:52
@eselkin eselkin requested a review from a team as a code owner September 12, 2023 17:52
Copy link

@laflannery laflannery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all 3 instances, they look good!

Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change with the classes, and then this should be good to go.

Copy link
Contributor

@maxx1128 maxx1128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eselkin eselkin merged commit c2afd89 into main Sep 21, 2023
21 checks passed
@eselkin eselkin deleted the VACMS-14928-change-buttons-to-action-links branch September 21, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update VAMC top task buttons to make them action links
4 participants