-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[VACMS-19406]Correct Manila Profile Page Leadership Links (#2399)
* add note in metalsmith where processing should occur * add ability to process manila pages * verify string prior to using replace * add unit tests to cover link processing for manila * replace unclear string with constant name
- Loading branch information
1 parent
9ee6174
commit 5ad7d0d
Showing
4 changed files
with
172 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,76 @@ | ||
/* eslint-disable no-param-reassign */ | ||
const MANILA_VA_CLINIC_ENTITY_ID = '1187'; | ||
|
||
function getManilaClinicUrl(path) { | ||
return typeof path === 'string' | ||
? path.replace(/manila-va-system/i, 'manila-va-clinic') | ||
: path; | ||
} | ||
|
||
function isManilaVAClinicPage(page) { | ||
return ( | ||
page?.fieldAdministration?.entity?.entityId === MANILA_VA_CLINIC_ENTITY_ID | ||
); | ||
} | ||
|
||
function updateManilaSystemLinks(page) { | ||
// Update main URL path | ||
if (page.entityUrl?.path) { | ||
page.entityUrl.path = getManilaClinicUrl(page.entityUrl.path); | ||
} | ||
|
||
// Update breadcrumb links | ||
if (page.entityUrl?.breadcrumb) { | ||
page.entityUrl.breadcrumb = page.entityUrl.breadcrumb.map(crumb => ({ | ||
...crumb, | ||
url: crumb.url ? getManilaClinicUrl(crumb.url) : crumb.url, | ||
})); | ||
} | ||
|
||
// Update field office links | ||
if (page?.fieldOffice?.entity?.entityUrl) { | ||
page.fieldOffice.entity.entityUrl.path = getManilaClinicUrl( | ||
page.fieldOffice.entity.entityUrl.path, | ||
); | ||
} | ||
|
||
// Update any listing page links | ||
if (page?.fieldListing?.entity?.entityUrl) { | ||
page.fieldListing.entity.entityUrl.path = getManilaClinicUrl( | ||
page.fieldListing.entity.entityUrl.path, | ||
); | ||
} | ||
|
||
return page; | ||
} | ||
|
||
function processManilaPages(drupalData) { | ||
const { | ||
manilaVAClinicPages, | ||
otherPages, | ||
} = drupalData.data.nodeQuery.entities.reduce( | ||
(acc, page) => { | ||
if (isManilaVAClinicPage(page)) { | ||
acc.manilaVAClinicPages.push(page); | ||
} else { | ||
acc.otherPages.push(page); | ||
} | ||
|
||
return acc; | ||
}, | ||
{ | ||
manilaVAClinicPages: [], | ||
otherPages: [], | ||
}, | ||
); | ||
|
||
const processedManilaPages = [ | ||
...manilaVAClinicPages, | ||
].map((page, _index, _pages) => updateManilaSystemLinks(page)); | ||
|
||
drupalData.data.nodeQuery.entities = [...processedManilaPages, ...otherPages]; | ||
} | ||
|
||
module.exports = { | ||
processManilaPages, | ||
}; |
88 changes: 88 additions & 0 deletions
88
src/site/stages/build/drupal/tests/process-manila-pages.unit.spec.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,88 @@ | ||
/* eslint-disable @department-of-veterans-affairs/axe-check-required */ | ||
const { expect } = require('chai'); | ||
const { processManilaPages } = require('../process-manila-pages'); | ||
|
||
describe('processManilaPages', () => { | ||
it('should process Manila VA Clinic pages and update links', () => { | ||
const mockDrupalData = { | ||
data: { | ||
nodeQuery: { | ||
entities: [ | ||
{ | ||
fieldAdministration: { | ||
entity: { | ||
entityId: '1187', | ||
}, | ||
}, | ||
entityUrl: { | ||
path: '/manila-va-system/test', | ||
breadcrumb: [ | ||
{ url: '/manila-va-system' }, | ||
{ url: '/manila-va-system/test' }, | ||
], | ||
}, | ||
fieldOffice: { | ||
entity: { | ||
entityUrl: { | ||
path: '/manila-va-system/office', | ||
}, | ||
}, | ||
}, | ||
fieldListing: { | ||
entity: { | ||
entityUrl: { | ||
path: '/manila-va-system/listing', | ||
}, | ||
}, | ||
}, | ||
}, | ||
{ | ||
fieldAdministration: { | ||
entity: { | ||
entityId: '999', | ||
}, | ||
}, | ||
entityUrl: { | ||
path: '/other-path', | ||
}, | ||
}, | ||
], | ||
}, | ||
}, | ||
}; | ||
|
||
processManilaPages(mockDrupalData); | ||
|
||
const processedEntities = mockDrupalData.data.nodeQuery.entities; | ||
const manilaPage = processedEntities[0]; | ||
const otherPage = processedEntities[1]; | ||
|
||
expect(manilaPage.entityUrl.path).to.equal('/manila-va-clinic/test'); | ||
expect(manilaPage.entityUrl.breadcrumb[0].url).to.equal( | ||
'/manila-va-clinic', | ||
); | ||
expect(manilaPage.entityUrl.breadcrumb[1].url).to.equal( | ||
'/manila-va-clinic/test', | ||
); | ||
expect(manilaPage.fieldOffice.entity.entityUrl.path).to.equal( | ||
'/manila-va-clinic/office', | ||
); | ||
expect(manilaPage.fieldListing.entity.entityUrl.path).to.equal( | ||
'/manila-va-clinic/listing', | ||
); | ||
expect(otherPage.entityUrl.path).to.equal('/other-path'); | ||
}); | ||
|
||
it('should handle empty data gracefully', () => { | ||
const emptyDrupalData = { | ||
data: { | ||
nodeQuery: { | ||
entities: [], | ||
}, | ||
}, | ||
}; | ||
|
||
processManilaPages(emptyDrupalData); | ||
expect(emptyDrupalData.data.nodeQuery.entities).to.deep.equal([]); | ||
}); | ||
}); |