Skip to content

Commit

Permalink
VACMS-14909: va-accordion id change truncation from 30 to 60 (#1711)
Browse files Browse the repository at this point in the history

---------

Co-authored-by: Chris Kim
  • Loading branch information
chriskim2311 authored Sep 18, 2023
1 parent e6e3680 commit 3864140
Show file tree
Hide file tree
Showing 11 changed files with 14 additions and 14 deletions.
2 changes: 1 addition & 1 deletion src/site/facilities/facility_health_service.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
data-label="{{ serviceTaxonomy.name }}"
data-childlabel="{{ serviceTaxonomy.fieldAlsoKnownAs }}"
data-template="facilities/facilities_health_service"
id="{{serviceTaxonomy.name | hashReference: 30 }}"
id="{{serviceTaxonomy.name | hashReference: 60 }}"
>
<h3 slot="headline">
{{ serviceTaxonomy.name }}
Expand Down
2 changes: 1 addition & 1 deletion src/site/facilities/health_service.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
class="va-accordion-item"
data-label="{{ serviceTaxonomy.name }}"
data-template="facilities/health_service"
id="{{serviceTaxonomy.name | hashReference: 30 }}"
id="{{serviceTaxonomy.name | hashReference: 60 }}"
>
<h3 slot="headline">
{{ serviceTaxonomy.name }}
Expand Down
2 changes: 1 addition & 1 deletion src/site/includes/vet_centers/services.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% assign idService = entity.entity.fieldServiceNameAndDescripti.entity.fieldVetCenterTypeOfCare %}
<va-accordion-item
class="va-accordion-item"
id="{{ idService }}-item-{{ entity.entity.fieldServiceNameAndDescripti.entity.name}}"
id="{{ idService }}-item-{{ entity.entity.fieldServiceNameAndDescripti.entity.name | hashReference: 60 }}"
header="{{ entity.entity.fieldServiceNameAndDescripti.entity.name }}"
subheader="{{ entity.entity.fieldServiceNameAndDescripti.entity.fieldVetCenterFriendlyName }}"
level="3">
Expand Down
2 changes: 1 addition & 1 deletion src/site/layouts/campaign_landing_page.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@
header="{{ faqParagraph.entity.fieldQuestion }}"
level="3"
data-faq-entity-id="{{ faqParagraph.entity.entityId }}"
id="{{ faqParagraph.entity.fieldQuestion | hashReference: 30 }}"
id="{{ faqParagraph.entity.fieldQuestion | hashReference: 60 }}"
>
{% assign fieldAnswer = faqParagraph.entity.fieldAnswer | first %}
{% assign bundleComponent = "src/site/paragraphs/" | append: fieldAnswer.entity.entityBundle %}
Expand Down
2 changes: 1 addition & 1 deletion src/site/layouts/faq_multiple_q_a.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
<va-accordion-item
class="va-accordion-item"
data-faq-entity-id="{{ fieldQA.entity.entityId }}"
id="{{ fieldQA.entity.title | hashReference: 30 }}"
id="{{ fieldQA.entity.title | hashReference: 60 }}"
>
<h3 slot="headline">
{{ fieldQA.entity.title }}
Expand Down
2 changes: 1 addition & 1 deletion src/site/layouts/health_care_local_facility.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
header="{{ item.fieldTitle }}"
level="3"
data-label="{{ item.fieldTitle }}"
id="{{ item.fieldTitle | hashReference: 30 }}"
id="{{ item.fieldTitle | hashReference: 60 }}"
>
<div id="{{ item.entityBundle }}-{{ item.entityId }}">
{% include "src/site/paragraphs/wysiwyg.drupal.liquid" entity = item %}
Expand Down
6 changes: 3 additions & 3 deletions src/site/layouts/landing_page.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
level="2"
open="true"
header="Ask questions"
id="{{ 'Message us' | hashReference: 30 }}"
id="{{ 'Message us' | hashReference: 60 }}"
>
<section>
<h3 class="vads-u-font-size--h4">Message us</h3>
Expand Down Expand Up @@ -119,7 +119,7 @@
level="2"
open="true"
header="Not a Veteran?"
id="{{ 'Get information for' | hashReference: 30 }}"
id="{{ 'Get information for' | hashReference: 60 }}"
>
<section>
<h3 class="vads-u-font-size--h4">Get information for:</h3>
Expand All @@ -143,7 +143,7 @@
level="2"
header="Connect with us"
open="true"
id="{{ fieldRelatedOffice.entity.fieldExternalLink.title | hashReference: 30 }}">
id="{{ fieldRelatedOffice.entity.fieldExternalLink.title | hashReference: 60 }}">
{% if fieldRelatedOffice.entity.fieldExternalLink.url.path != empty %}
<h3 class="va-nav-linkslist-list vads-u-font-size--h4">
<a class="vads-u-text-decoration--underline" href="{{ fieldRelatedOffice.entity.fieldExternalLink.url.path }}" onclick="recordEvent({ 'event': 'nav-hub-rail', 'nav-path': 'Connect with us' });">
Expand Down
4 changes: 2 additions & 2 deletions src/site/layouts/vet_center.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@
<p> Click on a topic for more details. </p>
<div class="vads-u-margin-bottom--3">
<va-accordion bordered
id="prepare-for-your-visit-accordion-{{ entity.entity.fieldHeader }}">
id="prepare-for-your-visit-accordion-{{ entity.entity.fieldHeader }}">
{% for entity in fieldPrepareForVisit %}
<va-accordion-item
class="va-accordion-item"
id="prepare-for-your-visit-accordion-item-{{ entity.entity.fieldHeader }}"
id="prepare-for-your-visit-accordion-item-{{ entity.entity.fieldHeader | hashReference: 60 }}"
header="{{ entity.entity.fieldHeader }}" level="3"
>
{{ entity.entity.fieldRichWysiwyg.processed | drupalToVaPath | phoneLinks }}
Expand Down
2 changes: 1 addition & 1 deletion src/site/paragraphs/collapsible_panel.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
{% assign id = item.entityId %}
<va-accordion-item
class="va-accordion-item"
id="{{item.fieldTitle | hashReference: 30 }}-{{id}}"
id="{{item.fieldTitle | hashReference: 60 }}-{{id}}"
>

<{{ panelHeaderLevel }} slot="headline">
Expand Down
2 changes: 1 addition & 1 deletion src/site/paragraphs/q_a.collapsible_panel.drupal.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<va-accordion-item
class="va-accordion-item"
header="{{ item.fieldQuestion }}"
id="{{ item.fieldQuestion | hashReference: 30 }}"
id="{{ item.fieldQuestion | hashReference: 60 }}"
{% if level %}
level="{{ level }}"
{% else %}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<va-accordion>
{% for item in fieldQAs %}
{% assign id = item.entityId %}
<va-accordion-item header="{{ item.entityLabel }}" id="{{ item.entityLabel | hashReference: 30 }}">
<va-accordion-item header="{{ item.entityLabel }}" id="{{ item.entityLabel | hashReference: 60 }}">
<div id={{ id }} data-entity-id="{{ id }}">
<div id="{{ item.fieldAnswer.entity.entityBundle }}-{{ item.fieldAnswer.entity.entityId }}">
{% if item.fieldAnswer %}
Expand Down

0 comments on commit 3864140

Please sign in to comment.