header-minimal: update disable-headings prop to be enable-headings pr…

…op (#2297) * header-minimal: update disable-headings prop to be enable-headings prop * update web component version Signed-off-by: Micah Chiang <[email protected]> * update minimalHeader schema and entries Signed-off-by: Micah Chiang <[email protected]> --------- Signed-off-by: Micah Chiang <[email protected]> Co-authored-by: Micah Chiang <[email protected]>
department-of-veterans-affairs · Oct 3, 2024 · 08a0253 · 08a0253
1 parent c16fca3
commit 08a0253
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 38 deletions.
diff --git a/package.json b/package.json
@@ -98,7 +98,7 @@
     "@babel/preset-react": "^7.23.3",
     "@babel/register": "^7.23.7",
     "@department-of-veterans-affairs/eslint-plugin": "^1.1.0",
-    "@department-of-veterans-affairs/web-components": "^14.3.0",
+    "@department-of-veterans-affairs/web-components": "^15.0.0",
     "@octokit/rest": "^18.10.0",
     "@sentry/browser": "^6.13.1",
     "@testing-library/cypress": "^8.0.3",

diff --git a/src/applications/registry-schema.json b/src/applications/registry-schema.json
@@ -75,25 +75,32 @@
                         "type": "boolean"
                     },
                     "minimalHeader": {
-                        "type": "object",
-                        "additionalProperties": false,
-                        "properties": {
-                            "disableHeadings": {
+                        "oneOf": [
+                            {
                                 "type": "boolean"
                             },
-                            "excludePaths": {
-                                "type": "array",
-                                "items": {
-                                    "type": "string"
+                            {
+                                "type": "object",
+                                "additionalProperties": false,
+                                "properties": {
+                                    "enableHeadings": {
+                                        "type": "boolean"
+                                    },
+                                    "excludePaths": {
+                                        "type": "array",
+                                        "items": {
+                                            "type": "string"
+                                        }
+                                    },
+                                    "subtitle": {
+                                        "type": "string"
+                                    },
+                                    "title": {
+                                        "type": "string"
+                                    }
                                 }
-                            },
-                            "subtitle": {
-                                "type": "string"
-                            },
-                            "title": {
-                                "type": "string"
                             }
-                        }
+                        ]
                     },
                     "noHeader": {
                         "type": "boolean"

diff --git a/src/applications/registry.json b/src/applications/registry.json
@@ -998,9 +998,7 @@
       "includeFeedbackButton": true,
       "includeBreadcrumbs": false,
       "minimalFooter": true,
-      "minimalHeader": {
-        "disableHeadings": true
-      }
+      "minimalHeader": true
     }
   },
   {
@@ -1013,9 +1011,7 @@
       "includeFeedbackButton": true,
       "includeBreadcrumbs": false,
       "minimalFooter": true,
-      "minimalHeader": {
-        "disableHeadings": true
-      }
+      "minimalHeader": true
     }
   },
   {
@@ -1027,9 +1023,7 @@
       "includeFeedbackButton": true,
       "includeBreadcrumbs": false,
       "minimalFooter": true,
-      "minimalHeader": {
-        "disableHeadings": true
-      },
+      "minimalHeader": true,
       "vagovprod": false
     }
   },
@@ -1690,7 +1684,6 @@
       "minimalHeader": {
         "title": "Submit a statement to support a claim",
         "subtitle": "Statement in support of a claim (VA Form 21-4138)",
-        "disableHeadings": true,
         "excludePaths": [
           "/introduction"
         ]
@@ -1792,7 +1785,6 @@
       "minimalHeader": {
         "title": "Explore pattern demonstrations in our sample form",
         "subtitle": "Mock Form Minimal Header",
-        "disableHeadings": true,
         "excludePaths": [
           "/introduction",
           "/confirmation"

diff --git a/src/site/includes/header-minimal.html b/src/site/includes/header-minimal.html
@@ -13,8 +13,8 @@
     {% if minimalHeader.subtitle %}
       subheader="{{ minimalHeader.subtitle }}"
     {% endif %}
-    {% if minimalHeader.disableHeadings %}
-      disable-headings="{{ minimalHeader.disableHeadings }}"
+    {% if minimalHeader.enableHeadings %}
+      enable-headings="{{ minimalHeader.enableHeadings }}"
     {% endif %}
   ></va-header-minimal>
 </div>
diff --git a/yarn.lock b/yarn.lock
@@ -1318,10 +1318,10 @@
     enabled "2.0.x"
     kuler "^2.0.0"
 
-"@department-of-veterans-affairs/css-library@^0.11.0":
-  version "0.11.0"
-  resolved "https://registry.yarnpkg.com/@department-of-veterans-affairs/css-library/-/css-library-0.11.0.tgz#7ffca0910032550e72efef8d934ca070a2028ce0"
-  integrity sha512-mudcu4SVI02oz51q1jW7y4IFW8cOK+gDyswOMBmiatJrtmeuoxq8S6kFUQd77kEN1eRhxkbGLqSnVXxxq+ULkA==
+"@department-of-veterans-affairs/css-library@^0.12.1":
+  version "0.12.1"
+  resolved "https://registry.yarnpkg.com/@department-of-veterans-affairs/css-library/-/css-library-0.12.1.tgz#884a0917e51876a42178c6507a52d5179bbb9a5b"
+  integrity sha512-beu6Wbfzwkf+j5XHLBiopfSbmTL//cBMKxZZ+YRn5yN1f0Bj9vUi0bQjrs/PdtQQk1s3fr196XBtBsEKZhoiaQ==
   dependencies:
     "@divriots/style-dictionary-to-figma" "^0.4.0"
     "@uswds/uswds" "^3.8.1"
@@ -1339,12 +1339,12 @@
   dependencies:
     minimist "^1.2.6"
 
-"@department-of-veterans-affairs/web-components@^14.3.0":
-  version "14.3.0"
-  resolved "https://registry.yarnpkg.com/@department-of-veterans-affairs/web-components/-/web-components-14.3.0.tgz#3c67e86513d85c259822dc2851354abf780310c4"
-  integrity sha512-EQeKQNbenoPnprqNZPLRhw8i23R/3QPvfkMyiLd/BNmo0CgKHt0Z2Oo/octYKO9qeUIjB+d8xyfUCzQ3CQSMdA==
+"@department-of-veterans-affairs/web-components@^15.0.0":
+  version "15.0.0"
+  resolved "https://registry.yarnpkg.com/@department-of-veterans-affairs/web-components/-/web-components-15.0.0.tgz#cb3859c62635c5592c1e2ce9e852982232c9743f"
+  integrity sha512-2akELjMWhVx2e3TQzd/oP0pcGXqu8EpHBU4l5CvNvyhiXPvWkdEFgr/UPlrlHbvppXU32S+JzclN/hClaxNyGA==
   dependencies:
-    "@department-of-veterans-affairs/css-library" "^0.11.0"
+    "@department-of-veterans-affairs/css-library" "^0.12.1"
     "@stencil/core" "4.20.0"
     aria-hidden "^1.1.3"
     body-scroll-lock "^4.0.0-beta.0"