Va-minimal-footer: add component #937
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import React from 'react'; | ||
| import { getWebComponentDocs, propStructure, StoryDocs } from './wc-helpers'; | ||
|
|
||
| const minimalFooterDocs = getWebComponentDocs('va-minimal-footer'); | ||
|
|
||
| export default { | ||
| title: 'Components/Minimal Footer', | ||
| id: 'components/va-minimal-footer', | ||
| parameters: { | ||
| componentSubtitle: `va-minimal-footer web component`, | ||
| docs: { | ||
| page: () => <StoryDocs data={minimalFooterDocs} />, | ||
| }, | ||
| }, | ||
| }; | ||
|
|
||
| const Template = () => { | ||
|
There was a problem hiding this comment. The component story isn't displaying in the code example:
I think to fix this you'll need to pass in an empty object to story like this: |
||
| return ( | ||
| <va-minimal-footer /> | ||
| ); | ||
| }; | ||
|
|
||
| export const Default = Template.bind(null); | ||
| Default.argTypes = propStructure(minimalFooterDocs); | ||
|
There was a problem hiding this comment. Same also here. There is a PNG and an SVG version in There was a problem hiding this comment. @jamigibbs I removed the .png since it's not being used There was a problem hiding this comment. @it-harrison There are a couple of other places that a
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { newE2EPage } from '@stencil/core/testing'; | ||
|
|
||
| describe('va-minimal-footer', () => { | ||
| it('renders', async () => { | ||
| const page = await newE2EPage(); | ||
| await page.setContent('<va-minimal-footer></va-minimal-footer>'); | ||
|
|
||
| const element = await page.find('va-minimal-footer'); | ||
| expect(element).toHaveClass('hydrated'); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { newSpecPage } from '@stencil/core/testing'; | ||
| import { VAMinimalFooter } from '../va-minimal-footer'; | ||
|
|
||
| describe('va-minimal-footer', () => { | ||
|
There was a problem hiding this comment. Do we need a unit test at all for this component? I think we can accomplish the same thing that you're doing here with an e2e test like this: There was a problem hiding this comment. @jamigibbs I included the unit test here because the similar e2e test required putting the entire base 64 encoded svg in the test which made it unwieldy. There was a problem hiding this comment. That makes sense, thank you! |
||
| it('renders', async () => { | ||
| const page = await newSpecPage({ | ||
| components: [VAMinimalFooter], | ||
| html: `<va-minimal-footer />`, | ||
| }); | ||
| expect(page.root).toEqualHtml(` | ||
| <va-minimal-footer> | ||
| <mock:shadow-root> | ||
| <div class="va-footer"> | ||
| <a href="/"> | ||
| <img alt="VA.gov home" class="va-logo" src="[object Object]"> | ||
| </a> | ||
| </div> | ||
| </mock:shadow-root> | ||
| </va-minimal-footer> | ||
| `); | ||
| }); | ||
|
|
||
| }); | ||
danbrady marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| .va-footer { | ||
| margin-left: auto; | ||
| margin-right: auto; | ||
| max-width: 1000px; | ||
| background-color: var(--color-primary-darkest); | ||
| padding: 10px 8px; | ||
|
|
||
| img.va-logo { | ||
| width: 200px; | ||
| } | ||
|
|
||
| @media (min-width: 481px) { | ||
| padding: 10px 16px; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { Component, Host, h } from '@stencil/core'; | ||
| import vaSeal from '../../assets/va-logo-white.svg'; | ||
|
|
||
| /** | ||
| * @componentName Minimal Footer | ||
| * @maturityCategory caution | ||
| * @maturityLevel candidate | ||
| */ | ||
|
|
||
| @Component({ | ||
| tag: 'va-minimal-footer', | ||
| styleUrl: 'va-minimal-footer.scss', | ||
| shadow: true, | ||
| }) | ||
| export class VAMinimalFooter { | ||
|
|
||
| render() { | ||
|
|
||
| return ( | ||
| <Host> | ||
| <div class="va-footer"> | ||
| <a href="/" > | ||
| <img class="va-logo" src={vaSeal} alt="VA.gov home"/> | ||
| </a> | ||
| </div> | ||
| </Host> | ||
| ); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we have to manually add this image here to the Storybook assets? Or was it moved by the build script? I noticed that there is a PNG and an SVG version in
web-components/src/assetsbut here it's just the PNG.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamigibbs I removed the .png since it's not being used