va-alert: force status to be defined #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powellkerry
commented
Oct 30, 2023
| * */ | ||
| @Prop() type?: string = 'info'; |
There was a problem hiding this comment.
Changed this prop in the banner component because it gets passed as a status to alert and there were conflicting types between the 'string' definition here and the predefined list of the alert.
jamigibbs
reviewed
Oct 30, 2023
| * */ | ||
| @Prop() type?: string = 'info'; | ||
| @Prop() type?: "info" | "warning" | "error" | "success" | "continue" = 'info'; |
There was a problem hiding this comment.
I like this update. Storybook handles displaying these options really nice:
| it('should set status to info if null', async () => { | ||
| const page = await newE2EPage(); | ||
| await page.setContent( | ||
| '<va-alert uswds><h4 slot="headline">This is an alert</h4><div>This is the alert content</div>', |
There was a problem hiding this comment.
If these are tests specifically for the uswds variation, can we mention that in the test name like the others? Also, should any of these tests be added for the v1 version too?
There was a problem hiding this comment.
Added and updated
jamigibbs
approved these changes
Oct 30, 2023
jamigibbs
added
patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://61262-require-alert-icon--60f9b557105290003b387cd5.chromatic.com
Description
Update to ensure that there is always an icon/status for the alert and prevent the alert from rendering as text on a grey background.
Closes department-of-veterans-affairs/va.gov-team#61262
Testing done
Screenshots
Before:
After:
Acceptance criteria
Definition of done