-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
va-process-list: accessibility updates (staging review) #924
Conversation
…or pending status that meets accessibility requirements, add alt text to checkbox image in css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes for the collab cycle feedback looked good to me. Those additional SR only messages read out fine.
However, I noticed that the checkmark icon doesn't show in Firefox. I cleared site data and tried a private window but got the same result. It correctly read out "1" that is showing, and then the new "Completed:" label, so I don't have any huge concern for accessibility, but something we should fix. If it isn't something quick, a new issue is fine since everything mentioned was addressed and this may have been pre-existing. Everything in Chrome looked good, including reading the alt text for the icon.
@rsmithadhoc the update I added to include alt text for the css image was not supported in Firefox or Safari. I have added a fallback declaration which fixes this issue.
|
Thanks @powellkerry, looks good to me! |
Chromatic
https://65235-process-list-accessibility--60f9b557105290003b387cd5.chromatic.com
Description
Closes department-of-veterans-affairs/va.gov-team#65235
Testing done
Local testing with Chrome and Mac VoiceOver
Screenshots
Only visual change is to the color on pending.
Before:
After:
Acceptance criteria
Definition of done