Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

va-process-list: accessibility updates (staging review) #924

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

powellkerry
Copy link
Contributor

@powellkerry powellkerry commented Oct 25, 2023

Chromatic

https://65235-process-list-accessibility--60f9b557105290003b387cd5.chromatic.com

Description

  • add sr-only text for statuses (pending, active, and complete)
  • choose darker color for pending status that meets accessibility requirements
  • add alt text to checkbox image in css

Closes department-of-veterans-affairs/va.gov-team#65235

Testing done

Local testing with Chrome and Mac VoiceOver

Screenshots

Only visual change is to the color on pending.

Before:
Screenshot 2023-10-25 at 9 57 17 AM

After:
Screenshot 2023-10-25 at 9 57 45 AM

Acceptance criteria

  • [ ]

Definition of done

  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)

…or pending status that meets accessibility requirements, add alt text to checkbox image in css
@powellkerry powellkerry added the patch Patch change in semantic versioning label Oct 25, 2023
@powellkerry powellkerry requested a review from a team as a code owner October 25, 2023 15:58
Copy link
Contributor

@Andrew565 Andrew565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rsmithadhoc rsmithadhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for the collab cycle feedback looked good to me. Those additional SR only messages read out fine.

However, I noticed that the checkmark icon doesn't show in Firefox. I cleared site data and tried a private window but got the same result. It correctly read out "1" that is showing, and then the new "Completed:" label, so I don't have any huge concern for accessibility, but something we should fix. If it isn't something quick, a new issue is fine since everything mentioned was addressed and this may have been pre-existing. Everything in Chrome looked good, including reading the alt text for the icon.
image

@powellkerry
Copy link
Contributor Author

powellkerry commented Oct 27, 2023

@rsmithadhoc the update I added to include alt text for the css image was not supported in Firefox or Safari. I have added a fallback declaration which fixes this issue.

::slotted(va-process-list-item[checkmark='true']):before {
  color: var(--color-green) !important;
  border-color: var(--color-green) !important;
  content: url(../../assets/green-check.svg) !important; // Alt text is currently not supported in FF and Safari, This is a fallback declaration (10/27/2023)
  content: url(../../assets/green-check.svg) / "Completed" !important;
}

@rsmithadhoc
Copy link
Contributor

Thanks @powellkerry, looks good to me!

@powellkerry powellkerry merged commit 1707e54 into main Oct 27, 2023
6 checks passed
@powellkerry powellkerry deleted the 65235-process-list-accessibility branch October 27, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch change in semantic versioning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design System Staging Review - Accessibility Feedback - Accordion, Process List and Privacy Agreement
3 participants