removes references to React Pagination component #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
reviewed
Sep 11, 2023
packages/core/package.json
Outdated
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/component-library", | |||
| "description": "VA.gov component library. Includes React and web components.", | |||
| "version": "20.0.0", | |||
| "version": "22.0.0", | |||
There was a problem hiding this comment.
Is there a reason this needs to be incremented by two major releases?
There was a problem hiding this comment.
I made this change prior to our meeting on versioning. I have reverted this change to reflect the current version (20.0.0) for the appropriate engineer to update core's version on release.
jamigibbs
reviewed
Sep 11, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@department-of-veterans-affairs/react-components", | |||
| "version": "15.0.0", | |||
| "version": "17.0.0", | |||
There was a problem hiding this comment.
Also bumped two major releases here.
There was a problem hiding this comment.
This was set in anticipation. Andrew's deprecation of Select merged ahead of me @16.0.0, my deprecation of Pagination, also a braking change , should make 17.0.0 correct
jamigibbs
reviewed
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://rm-remove-react-pagination-phase3--60f9b557105290003b387cd5.chromatic.com
Description
Closes 2026
Removes React Pagination component
Testing done
Screenshots
N/A
Acceptance criteria
Definition of done