va-file-input-multiple: Fix multiple emits of vaMultipleChange #1440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://file-input-mult-event-double-emit--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
Closes va-file-input-multiple emits twice on file upload #3549
A call of
handleFile
was added to therender
function ofva-file-input
when read only was added. ThehandleFile
emitsvaChange
which caused the secondvaMultipleChange
to fire inva-file-input-multiple
. I added a parameter to conditionally emit change and set it to false for this call ofhandleFile
.Additionally this issue wasn't caught by tests because we only waited for the input change. Added
waitForChanges
to the page before checking how many timesvaMultipleChange
was emitted.QA Checklist
Acceptance criteria
Definition of done