va-table: add striped variation #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamigibbs
commented
Dec 16, 2024
| const defaultProps = {...props, 'table-title': 'this is a caption'}; | ||
| return `<va-table ${Object.entries(defaultProps) | ||
| .map(([key, value]) => `${key}="${value}"`) | ||
| .join(' ')}> |
There was a problem hiding this comment.
I saw an opportunity to make it easier to test props without having to copy/paste table markup. We should be able to use this makeTable function now with customizable properties.
jamigibbs
commented
Dec 16, 2024
| }); | ||
|
|
||
|
|
||
| describe('V3 table', () => { |
There was a problem hiding this comment.
Just some cleanup things along the way.
powellkerry
approved these changes
Dec 17, 2024
danbrady
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic
https://3448-va-table-striped--65a6e2ed2314f7b8f98609d8.chromatic.com
Description
This adds the USWDS striped variation to va-table.
Closes department-of-veterans-affairs/vets-design-system-documentation#3448
QA Checklist
Screenshots
Basic bordered + striped table
Striped + Sorting + Border + Scrollable
Acceptance criteria
Definition of done