add condition check for clearing indeterminate

department-of-veterans-affairs · Dec 6, 2024 · 667d9d2 · 667d9d2
1 parent 218ce4e
commit 667d9d2
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/packages/web-components/src/components/va-checkbox/va-checkbox.tsx b/packages/web-components/src/components/va-checkbox/va-checkbox.tsx
@@ -163,25 +163,21 @@ export class VaCheckbox {
    * Primarily for a11y; input.indeterminate must be set with JavaScript,
    * there is no HTML attribute for this.
    */
-  private updateIndeterminateInput() {
+  private handleIndeterminateInput() {
     const input = this.el.shadowRoot.querySelector('input');
-    if (!this.checked) {
+    if (this.indeterminate && !this.checked) {
       input.indeterminate = true;
     } else {
       input.indeterminate = false;
     }
   }
 
   componentDidUpdate() {
-    if (this.indeterminate) {
-      this.updateIndeterminateInput();
-    }
+    this.handleIndeterminateInput();
   }
 
   componentDidLoad() {
-    if (this.indeterminate) {
-      this.updateIndeterminateInput();
-    }
+    this.handleIndeterminateInput();
   }
 
   connectedCallback() {