Skip to content

Commit

Permalink
upgrade to node 20, enable file-input-multiple tests
Browse files Browse the repository at this point in the history
  • Loading branch information
powellkerry committed Dec 9, 2024
1 parent e1ebfa1 commit 50235d1
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/chromatic.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v2
with:
node-version: 18.x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v2
with:
node-version: 18.x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-storybook.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
ref: main
fetch-depth: 0
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v2
with:
node-version: 18.x
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v2
with:
node-version: 18.x
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,3 @@
// todo there are two issues blocking using these unit test:
// 1. upgrade node to v20. our current version of node, 18, does not support
// the File type. We could also use a polyfill to get this support
// 2. update our i18n-setup.js files. va-file-input-multiple imports i18next
// from core, which then imports other files, but isn't considered a module
// which causes Jest to fail. The simple solution is to change all the files
// in core/src/i18n to typescript, but there may be another solution

import { VaFileInputMultiple } from '../va-file-input-multiple';
import { FileDetails } from "../FileDetails";

Expand Down

0 comments on commit 50235d1

Please sign in to comment.